| Message ID | 20220306215753.3156276-7-bigeasy@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | net: Convert user to netif_rx(), part 3. | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=620752
---Test result---
Test Summary:
CheckPatch FAIL 1.03 seconds
GitLint FAIL 0.45 seconds
SubjectPrefix FAIL 0.32 seconds
BuildKernel PASS 33.53 seconds
BuildKernel32 PASS 29.85 seconds
Incremental Build with patchesPASS 39.86 seconds
TestRunner: Setup PASS 525.29 seconds
TestRunner: l2cap-tester PASS 16.50 seconds
TestRunner: bnep-tester PASS 6.45 seconds
TestRunner: mgmt-tester PASS 107.98 seconds
TestRunner: rfcomm-tester PASS 8.33 seconds
TestRunner: sco-tester PASS 8.05 seconds
TestRunner: smp-tester PASS 8.16 seconds
TestRunner: userchan-tester PASS 6.73 seconds
Details
##############################
Test: CheckPatch - FAIL - 1.03 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[net-next,06/10] bluetooth: Use netif_rx().\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#68:
baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12770937.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL - 0.45 seconds
Run gitlint with rule in .gitlint
[net-next,06/10] bluetooth: Use netif_rx().
1: T3 Title has trailing punctuation (.): "[net-next,06/10] bluetooth: Use netif_rx()."
4: B1 Line exceeds max length (83>80): " baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")"
##############################
Test: SubjectPrefix - FAIL - 0.32 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index 8e8c075411530..215af9b3b5895 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -240,7 +240,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev) if (!skb_cp) return NET_RX_DROP; - return netif_rx_ni(skb_cp); + return netif_rx(skb_cp); } static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev, diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c index 40baa6b7321ae..5a6a49885ab66 100644 --- a/net/bluetooth/bnep/core.c +++ b/net/bluetooth/bnep/core.c @@ -400,7 +400,7 @@ static int bnep_rx_frame(struct bnep_session *s, struct sk_buff *skb) dev->stats.rx_packets++; nskb->ip_summed = CHECKSUM_NONE; nskb->protocol = eth_type_trans(nskb, dev); - netif_rx_ni(nskb); + netif_rx(nskb); return 0; badframe:
Since commit baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") the function netif_rx() can be used in preemptible/thread context as well as in interrupt context. Use netif_rx(). Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Johan Hedberg <johan.hedberg@gmail.com> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: linux-bluetooth@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- net/bluetooth/6lowpan.c | 2 +- net/bluetooth/bnep/core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)