| Message ID | 20220305232420.201726-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 5c7d28c6f6d4e739bafb92f913ec8ff982239c0e |
| Headers | show |
| Series | power: supply: Add missing charge restart voltages | expand |
Hi, On Sun, Mar 06, 2022 at 12:24:20AM +0100, Linus Walleij wrote: > Two of the batteries were missing charging restart voltages, > meaning they can drain if the algorithm relies on restarting > charging at this voltage. Fix it up. > > Fixes: c8aee3f41cb8 ("power: supply: Static data for Samsung batteries") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- Thanks, queued. -- Sebastian > drivers/power/supply/samsung-sdi-battery.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/power/supply/samsung-sdi-battery.c b/drivers/power/supply/samsung-sdi-battery.c > index 9d59f277f519..b33daab798b9 100644 > --- a/drivers/power/supply/samsung-sdi-battery.c > +++ b/drivers/power/supply/samsung-sdi-battery.c > @@ -824,6 +824,7 @@ static struct samsung_sdi_battery samsung_sdi_batteries[] = { > .constant_charge_current_max_ua = 900000, > .constant_charge_voltage_max_uv = 4200000, > .charge_term_current_ua = 200000, > + .charge_restart_voltage_uv = 4170000, > .maintenance_charge = samsung_maint_charge_table, > .maintenance_charge_size = ARRAY_SIZE(samsung_maint_charge_table), > .alert_low_temp_charge_current_ua = 300000, > @@ -867,6 +868,7 @@ static struct samsung_sdi_battery samsung_sdi_batteries[] = { > .constant_charge_current_max_ua = 1500000, > .constant_charge_voltage_max_uv = 4350000, > .charge_term_current_ua = 120000, > + .charge_restart_voltage_uv = 4300000, > .maintenance_charge = samsung_maint_charge_table, > .maintenance_charge_size = ARRAY_SIZE(samsung_maint_charge_table), > .alert_low_temp_charge_current_ua = 300000, > -- > 2.35.1 >
diff --git a/drivers/power/supply/samsung-sdi-battery.c b/drivers/power/supply/samsung-sdi-battery.c index 9d59f277f519..b33daab798b9 100644 --- a/drivers/power/supply/samsung-sdi-battery.c +++ b/drivers/power/supply/samsung-sdi-battery.c @@ -824,6 +824,7 @@ static struct samsung_sdi_battery samsung_sdi_batteries[] = { .constant_charge_current_max_ua = 900000, .constant_charge_voltage_max_uv = 4200000, .charge_term_current_ua = 200000, + .charge_restart_voltage_uv = 4170000, .maintenance_charge = samsung_maint_charge_table, .maintenance_charge_size = ARRAY_SIZE(samsung_maint_charge_table), .alert_low_temp_charge_current_ua = 300000, @@ -867,6 +868,7 @@ static struct samsung_sdi_battery samsung_sdi_batteries[] = { .constant_charge_current_max_ua = 1500000, .constant_charge_voltage_max_uv = 4350000, .charge_term_current_ua = 120000, + .charge_restart_voltage_uv = 4300000, .maintenance_charge = samsung_maint_charge_table, .maintenance_charge_size = ARRAY_SIZE(samsung_maint_charge_table), .alert_low_temp_charge_current_ua = 300000,
Two of the batteries were missing charging restart voltages, meaning they can drain if the algorithm relies on restarting charging at this voltage. Fix it up. Fixes: c8aee3f41cb8 ("power: supply: Static data for Samsung batteries") Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/power/supply/samsung-sdi-battery.c | 2 ++ 1 file changed, 2 insertions(+)