| Message ID | 20220225231451.2652330-2-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | babc92da5928f81af951663fc436997352e02d3a |
| Headers | show |
| Series | [v3,01/18] ACPI: property: Always return -ENOENT if there are no more references | expand |
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c index d0986bda29640..3fceb4681ec9f 100644 --- a/drivers/acpi/property.c +++ b/drivers/acpi/property.c @@ -685,7 +685,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode, */ if (obj->type == ACPI_TYPE_LOCAL_REFERENCE) { if (index) - return -EINVAL; + return -ENOENT; device = acpi_fetch_acpi_dev(obj->reference.handle); if (!device)
__acpi_node_get_property_reference() is documented to return -ENOENT if the caller requests a property reference at an index that does not exist, not -EINVAL which it actually does. Fix this by returning -ENOENT consistenly, independently of whether the property value is a plain reference or a package. Fixes: c343bc2ce2c6 ("ACPI: properties: Align return codes of __acpi_node_get_property_reference()") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/acpi/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)