| Message ID | 1443799181-50409-5-git-send-email-yingjoe.chen@mediatek.com |
|---|---|
| State | Accepted |
| Commit | d186a394bb98e9da199b72ce0498fb0f96832e17 |
| Headers | show |
On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: > Hello, > > On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote: > > Add arch timer node to enable arch-timer support. MT8135 firmware > > doesn't correctly setup arch-timer frequency and CNTVOFF, add > > properties to workaround this. > > > > This also set cpu enable-method to enable SMP. > > > > Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> > > kernelci.org started detecting new boot failures for the mt8135-evb in > the arm-soc tree[1], and the boot failures were bisected down to this > patch, which landed upstream in the form of commit d186a394bb98 (ARM: > dts: mt8135: enable basic SMP bringup for mt8135) > > Maybe this new SMP support requires updating the firmware on the board > as well? If so, the changelog should've been a bit more explicit > about firmware dependencies. Kevin, Thanks for testing. No, it doesn't need new firmware. Will test to see what's going wrong. Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote: > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: >> Hello, >> >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote: >> > Add arch timer node to enable arch-timer support. MT8135 firmware >> > doesn't correctly setup arch-timer frequency and CNTVOFF, add >> > properties to workaround this. >> > >> > This also set cpu enable-method to enable SMP. >> > >> > Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> >> >> kernelci.org started detecting new boot failures for the mt8135-evb in >> the arm-soc tree[1], and the boot failures were bisected down to this >> patch, which landed upstream in the form of commit d186a394bb98 (ARM: >> dts: mt8135: enable basic SMP bringup for mt8135) >> >> Maybe this new SMP support requires updating the firmware on the board >> as well? If so, the changelog should've been a bit more explicit >> about firmware dependencies. > > Kevin, > > Thanks for testing. > > No, it doesn't need new firmware. Will test to see what's going wrong. Thanks for following up. I'll be glad to test any patches if you have anything you'd like me to test. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Eddie Huang <eddie.huang@mediatek.com> writes: > Hi Kevin, > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote: >> > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: >> >> Hello, >> >> >> >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote: >> >> > Add arch timer node to enable arch-timer support. MT8135 firmware >> >> > doesn't correctly setup arch-timer frequency and CNTVOFF, add >> >> > properties to workaround this. >> >> > >> >> > This also set cpu enable-method to enable SMP. >> >> > >> >> > Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> >> >> >> >> kernelci.org started detecting new boot failures for the mt8135-evb in >> >> the arm-soc tree[1], and the boot failures were bisected down to this >> >> patch, which landed upstream in the form of commit d186a394bb98 (ARM: >> >> dts: mt8135: enable basic SMP bringup for mt8135) >> >> >> >> Maybe this new SMP support requires updating the firmware on the board >> >> as well? If so, the changelog should've been a bit more explicit >> >> about firmware dependencies. >> > >> > Kevin, >> > >> > Thanks for testing. >> > >> > No, it doesn't need new firmware. Will test to see what's going wrong. >> >> Thanks for following up. I'll be glad to test any patches if you have >> anything you'd like me to test. > > You need "clockevents/drivers/mtk: Fix spurious interrupt leading to > crash" (https://lkml.org/lkml/2015/8/24/803) > > Daniel Lezcano already applied this patch in his tree for 4.4. > (https://git.linaro.org/people/daniel.lezcano/linux.git) > Thanks for letting us know. In the future, these kinds of cross-tree dependencies are important to mention in the cover letter of the pull request so we can setup dependency branches and keep arm-soc/for-next building and booting. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Eddie, Eddie Huang <eddie.huang@mediatek.com> writes: > On Tue, 2015-11-10 at 17:16 -0800, Kevin Hilman wrote: >> Hi Eddie, >> >> [...] >> >> > I check the log [0], >> >> Thanks for checking into this boot failure. >> >> > it seems first time mt8135-evbp1 boot to kernel >> > shell successfully, then boot again. In the second time, mt8135 stay in >> > fastboot mode, waiting host send boot image, then timeout. >> >> Actually, it never gets to a shell the first time. If you look closely, >> the target reboots as soon as userspace starts. Look for the PYBOOT >> line which says "finished booting, starting userspace" >> >> Later on, pyboot thinks it finds a root shell due to finding '#' >> characters, but clearly it never got to a shell. >> >> > I download zImage and dtb in [1], and kernel run to shell successfully >> > on my platform. >> >> Are you can you try using a ramdisk as well? You can use the pre-built >> one here: >> http://storage.kernelci.org/images/rootfs/buildroot/armel/rootfs.cpio.gz >> > > Yes, I tried this ramdisk, and I can reproduce fail issue. > OK, good. Thanks for looking into it. >> Please check my boot logs to see how I'm generating the boot.img file >> (search for mkbootimg) with a kernel/dtb/ramdisk. It may be possible >> that the kernel image size with a ramdisk is breaking some of the >> assumptions in the fastboot mode. I've seen problems like this on other >> platforms due to hard-coded sizes/addresses in the boot firmware. >> > > MT8135 allocate 10MB for BOOT partition, but the test boot.img is 11MB, > thus cause user space fail. Aha, I was right! ;) > I will prepare new firmware that extend BOOT > partition to 16MB. and put new firmware on Howard's github. I will mail > to you when I am ready.. Great, thanks for working on this. Any chance of making it even bigger? We're working on running some more automated testing from a ramdisk, and those ramdisks will be easily 30-50 Mb with modules included and a rootfs with extra tests. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Eddie, Kevin Hilman <khilman@kernel.org> writes: > Eddie Huang <eddie.huang@mediatek.com> writes: > >> On Tue, 2015-11-10 at 17:16 -0800, Kevin Hilman wrote: >>> Hi Eddie, >>> >>> [...] >>> >>> > I check the log [0], >>> >>> Thanks for checking into this boot failure. >>> >>> > it seems first time mt8135-evbp1 boot to kernel >>> > shell successfully, then boot again. In the second time, mt8135 stay in >>> > fastboot mode, waiting host send boot image, then timeout. >>> >>> Actually, it never gets to a shell the first time. If you look closely, >>> the target reboots as soon as userspace starts. Look for the PYBOOT >>> line which says "finished booting, starting userspace" >>> >>> Later on, pyboot thinks it finds a root shell due to finding '#' >>> characters, but clearly it never got to a shell. >>> >>> > I download zImage and dtb in [1], and kernel run to shell successfully >>> > on my platform. >>> >>> Are you can you try using a ramdisk as well? You can use the pre-built >>> one here: >>> http://storage.kernelci.org/images/rootfs/buildroot/armel/rootfs.cpio.gz >>> >> >> Yes, I tried this ramdisk, and I can reproduce fail issue. >> > > OK, good. Thanks for looking into it. > >>> Please check my boot logs to see how I'm generating the boot.img file >>> (search for mkbootimg) with a kernel/dtb/ramdisk. It may be possible >>> that the kernel image size with a ramdisk is breaking some of the >>> assumptions in the fastboot mode. I've seen problems like this on other >>> platforms due to hard-coded sizes/addresses in the boot firmware. >>> >> >> MT8135 allocate 10MB for BOOT partition, but the test boot.img is 11MB, >> thus cause user space fail. > > Aha, I was right! ;) Also notice in kernelci.org that the mt8173 board has also been failing to boot in mainline[1]. I wonder if this same limitation exists in the mt8173 boot firmware? Kevin [1] http://kernelci.org/boot/mt8173-evb/job/mainline/kernel/v4.3-11553-g8d3de01cfa37/defconfig/defconfig/lab/lab-khilman/?_id=5643bc3959b5145c9e0918f4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi index 08371db..cb99b02 100644 --- a/arch/arm/boot/dts/mt8135.dtsi +++ b/arch/arm/boot/dts/mt8135.dtsi @@ -46,6 +46,7 @@ cpus { #address-cells = <1>; #size-cells = <0>; + enable-method = "mediatek,mt81xx-tz-smp"; cpu0: cpu@0 { device_type = "cpu"; @@ -72,6 +73,17 @@ }; }; + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + trustzone-bootinfo@80002000 { + compatible = "mediatek,trustzone-bootinfo"; + reg = <0 0x80002000 0 0x1000>; + }; + }; + clocks { #address-cells = <2>; #size-cells = <2>; @@ -97,6 +109,21 @@ }; }; + timer { + compatible = "arm,armv7-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | + IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | + IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | + IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | + IRQ_TYPE_LEVEL_LOW)>; + clock-frequency = <13000000>; + arm,cpu-registers-not-fw-configured; + }; + soc { #address-cells = <2>; #size-cells = <2>;
Add arch timer node to enable arch-timer support. MT8135 firmware doesn't correctly setup arch-timer frequency and CNTVOFF, add properties to workaround this. This also set cpu enable-method to enable SMP. Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> --- arch/arm/boot/dts/mt8135.dtsi | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)