diff mbox series

[2/2] selftests/damon: make selftests executable

Message ID 20220218001017.3500673-3-yuanchu@google.com
State New
Headers show
Series selftests/damon: trivial fixes | expand

Commit Message

Yuanchu Xie Feb. 18, 2022, 12:10 a.m. UTC 
The damon selftests do not have the executable bit on. We fix that by
setting the x bits on the .sh files similar to other existing shell
selftests.

Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases")
Signed-off-by: Yuanchu Xie <yuanchu@google.com>
---
 tools/testing/selftests/damon/debugfs_attrs.sh                 | 0
 tools/testing/selftests/damon/debugfs_empty_targets.sh         | 0
 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0
 tools/testing/selftests/damon/debugfs_schemes.sh               | 0
 tools/testing/selftests/damon/debugfs_target_ids.sh            | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh
 mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh

Comments

SeongJae Park Feb. 18, 2022, 7:52 a.m. UTC | #1 
Hello Yuanchu,

Thank you for this patch!

On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote:

> The damon selftests do not have the executable bit on. We fix that by
> setting the x bits on the .sh files similar to other existing shell
> selftests.
> 
> Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases")
> Signed-off-by: Yuanchu Xie <yuanchu@google.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/debugfs_attrs.sh                 | 0
>  tools/testing/selftests/damon/debugfs_empty_targets.sh         | 0
>  tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0
>  tools/testing/selftests/damon/debugfs_schemes.sh               | 0
>  tools/testing/selftests/damon/debugfs_target_ids.sh            | 0
>  5 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh
> 
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh
> old mode 100644
> new mode 100755
> -- 
> 2.35.1.265.g69c8d7142f-goog
Greg KH Feb. 18, 2022, 8:01 a.m. UTC | #2 
On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote:
> Hello Yuanchu,
> 
> Thank you for this patch!
> 
> On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote:
> 
> > The damon selftests do not have the executable bit on. We fix that by
> > setting the x bits on the .sh files similar to other existing shell
> > selftests.
> > 
> > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases")
> > Signed-off-by: Yuanchu Xie <yuanchu@google.com>
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

This type of change does not work outside of git, so why not just make
the tool that calls these scripts not care about the executable bit like
we do for other scripts?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
old mode 100644
new mode 100755
diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh
old mode 100644
new mode 100755
diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
old mode 100644
new mode 100755
diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh
old mode 100644
new mode 100755
diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh
old mode 100644
new mode 100755