diff mbox

[API-NEXT/PATCH] validation: classification: Queue parameter init calls

Message ID 1443597899-4354-1-git-send-email-bala.manoharan@linaro.org
State Accepted
Commit 0d919c3af19140b4d932922b3834861ba904f487
Headers show

Commit Message

Balasubramanian Manoharan Sept. 30, 2015, 7:24 a.m. UTC 
Add missing odp_queue_param_init()
Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
 test/validation/classification/odp_classification_basic.c | 1 +
 test/validation/classification/odp_classification_tests.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Bill Fischofer Sept. 30, 2015, 10:24 a.m. UTC | #1 
On Wed, Sep 30, 2015 at 2:24 AM, Balasubramanian Manoharan <
bala.manoharan@linaro.org> wrote:

> Add missing odp_queue_param_init()
> Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823
>
> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  test/validation/classification/odp_classification_basic.c | 1 +
>  test/validation/classification/odp_classification_tests.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/test/validation/classification/odp_classification_basic.c
> b/test/validation/classification/odp_classification_basic.c
> index d60eafd..c063b88 100644
> --- a/test/validation/classification/odp_classification_basic.c
> +++ b/test/validation/classification/odp_classification_basic.c
> @@ -76,6 +76,7 @@ void classification_test_cos_set_queue(void)
>         cos_queue = odp_cos_create(cosname);
>         CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
>
> +       odp_queue_param_init(&qparam);
>         qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
> diff --git a/test/validation/classification/odp_classification_tests.c
> b/test/validation/classification/odp_classification_tests.c
> index 69a71b1..0fb624d 100644
> --- a/test/validation/classification/odp_classification_tests.c
> +++ b/test/validation/classification/odp_classification_tests.c
> @@ -408,6 +408,7 @@ void configure_cls_pmr_chain(void)
>         cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
>         CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] != ODP_COS_INVALID);
>
> +       odp_queue_param_init(&qparam);
>         qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Mike Holmes Sept. 30, 2015, 3:43 p.m. UTC | #2 
On 30 September 2015 at 06:24, Bill Fischofer <bill.fischofer@linaro.org>
wrote:

>
>
> On Wed, Sep 30, 2015 at 2:24 AM, Balasubramanian Manoharan <
> bala.manoharan@linaro.org> wrote:
>
>> Add missing odp_queue_param_init()
>> Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823
>>
>> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>
>
Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org>

Fixes Bug 1823


>
>
>> ---
>>  test/validation/classification/odp_classification_basic.c | 1 +
>>  test/validation/classification/odp_classification_tests.c | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/test/validation/classification/odp_classification_basic.c
>> b/test/validation/classification/odp_classification_basic.c
>> index d60eafd..c063b88 100644
>> --- a/test/validation/classification/odp_classification_basic.c
>> +++ b/test/validation/classification/odp_classification_basic.c
>> @@ -76,6 +76,7 @@ void classification_test_cos_set_queue(void)
>>         cos_queue = odp_cos_create(cosname);
>>         CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
>>
>> +       odp_queue_param_init(&qparam);
>>         qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
>>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
>> diff --git a/test/validation/classification/odp_classification_tests.c
>> b/test/validation/classification/odp_classification_tests.c
>> index 69a71b1..0fb624d 100644
>> --- a/test/validation/classification/odp_classification_tests.c
>> +++ b/test/validation/classification/odp_classification_tests.c
>> @@ -408,6 +408,7 @@ void configure_cls_pmr_chain(void)
>>         cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
>>         CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] != ODP_COS_INVALID);
>>
>> +       odp_queue_param_init(&qparam);
>>         qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
>>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
>> --
>> 1.9.1
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
Anders Roxell Sept. 30, 2015, 5:53 p.m. UTC | #3 
On 2015-09-30 11:43, Mike Holmes wrote:
> On 30 September 2015 at 06:24, Bill Fischofer <bill.fischofer@linaro.org>
> wrote:
> 
> >
> >
> > On Wed, Sep 30, 2015 at 2:24 AM, Balasubramanian Manoharan <
> > bala.manoharan@linaro.org> wrote:
> >
> >> Add missing odp_queue_param_init()
> >> Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823
> >>
> >> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
> >>
> >
> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>
> >
> Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-and-tested-by: Anders Roxell <anders.roxell@linaro.org>

> 
> Fixes Bug 1823
> 
> 
> >
> >
> >> ---
> >>  test/validation/classification/odp_classification_basic.c | 1 +
> >>  test/validation/classification/odp_classification_tests.c | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/test/validation/classification/odp_classification_basic.c
> >> b/test/validation/classification/odp_classification_basic.c
> >> index d60eafd..c063b88 100644
> >> --- a/test/validation/classification/odp_classification_basic.c
> >> +++ b/test/validation/classification/odp_classification_basic.c
> >> @@ -76,6 +76,7 @@ void classification_test_cos_set_queue(void)
> >>         cos_queue = odp_cos_create(cosname);
> >>         CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
> >>
> >> +       odp_queue_param_init(&qparam);
> >>         qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
> >>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
> >>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
> >> diff --git a/test/validation/classification/odp_classification_tests.c
> >> b/test/validation/classification/odp_classification_tests.c
> >> index 69a71b1..0fb624d 100644
> >> --- a/test/validation/classification/odp_classification_tests.c
> >> +++ b/test/validation/classification/odp_classification_tests.c
> >> @@ -408,6 +408,7 @@ void configure_cls_pmr_chain(void)
> >>         cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
> >>         CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] != ODP_COS_INVALID);
> >>
> >> +       odp_queue_param_init(&qparam);
> >>         qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
> >>         qparam.sched.sync = ODP_SCHED_SYNC_NONE;
> >>         qparam.sched.group = ODP_SCHED_GROUP_ALL;
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> lng-odp mailing list
> >> lng-odp@lists.linaro.org
> >> https://lists.linaro.org/mailman/listinfo/lng-odp
> >>
> >
> >
> > _______________________________________________
> > lng-odp mailing list
> > lng-odp@lists.linaro.org
> > https://lists.linaro.org/mailman/listinfo/lng-odp
> >
> >
> 
> 
> -- 
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs

> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
Maxim Uvarov Oct. 1, 2015, 10:36 a.m. UTC | #4 
Merged,
Thanks!

(looks like it's the most tested one liner we had before ;)

On 09/30/15 20:53, Anders Roxell wrote:
> On 2015-09-30 11:43, Mike Holmes wrote:
>> On 30 September 2015 at 06:24, Bill Fischofer <bill.fischofer@linaro.org>
>> wrote:
>>
>>>
>>> On Wed, Sep 30, 2015 at 2:24 AM, Balasubramanian Manoharan <
>>> bala.manoharan@linaro.org> wrote:
>>>
>>>> Add missing odp_queue_param_init()
>>>> Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823
>>>>
>>>> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>>>>
>>> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>
>>>
>> Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org>
> Reviewed-and-tested-by: Anders Roxell <anders.roxell@linaro.org>
>
>> Fixes Bug 1823
>>
>>
>>>
>>>> ---
>>>>   test/validation/classification/odp_classification_basic.c | 1 +
>>>>   test/validation/classification/odp_classification_tests.c | 1 +
>>>>   2 files changed, 2 insertions(+)
>>>>
>>>> diff --git a/test/validation/classification/odp_classification_basic.c
>>>> b/test/validation/classification/odp_classification_basic.c
>>>> index d60eafd..c063b88 100644
>>>> --- a/test/validation/classification/odp_classification_basic.c
>>>> +++ b/test/validation/classification/odp_classification_basic.c
>>>> @@ -76,6 +76,7 @@ void classification_test_cos_set_queue(void)
>>>>          cos_queue = odp_cos_create(cosname);
>>>>          CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
>>>>
>>>> +       odp_queue_param_init(&qparam);
>>>>          qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
>>>>          qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>>>          qparam.sched.group = ODP_SCHED_GROUP_ALL;
>>>> diff --git a/test/validation/classification/odp_classification_tests.c
>>>> b/test/validation/classification/odp_classification_tests.c
>>>> index 69a71b1..0fb624d 100644
>>>> --- a/test/validation/classification/odp_classification_tests.c
>>>> +++ b/test/validation/classification/odp_classification_tests.c
>>>> @@ -408,6 +408,7 @@ void configure_cls_pmr_chain(void)
>>>>          cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
>>>>          CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] != ODP_COS_INVALID);
>>>>
>>>> +       odp_queue_param_init(&qparam);
>>>>          qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
>>>>          qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>>>          qparam.sched.group = ODP_SCHED_GROUP_ALL;
>>>> --
>>>> 1.9.1
>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>>
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>>
>>
>> -- 
>> Mike Holmes
>> Technical Manager - Linaro Networking Group
>> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Mike Holmes Oct. 1, 2015, 1:37 p.m. UTC | #5 
On 1 October 2015 at 06:36, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> Merged,
> Thanks!
>
> (looks like it's the most tested one liner we had before ;)\


That is because the fault got into the repo and broke the build for two
weeks.

Fixed now
https://ci.linaro.org/view/odp-ci/job/odp-publish/GIT_BRANCH=api-next,build_type=lcov,label=docker-utopic,platform_type=generic/


>
>
> On 09/30/15 20:53, Anders Roxell wrote:
>
>> On 2015-09-30 11:43, Mike Holmes wrote:
>>
>>> On 30 September 2015 at 06:24, Bill Fischofer <bill.fischofer@linaro.org
>>> >
>>> wrote:
>>>
>>>
>>>> On Wed, Sep 30, 2015 at 2:24 AM, Balasubramanian Manoharan <
>>>> bala.manoharan@linaro.org> wrote:
>>>>
>>>> Add missing odp_queue_param_init()
>>>>> Fixes: https://bugs.linaro.org/show_bug.cgi?id=1823
>>>>>
>>>>> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>>>>>
>>>>> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>
>>>>
>>>> Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org>
>>>
>> Reviewed-and-tested-by: Anders Roxell <anders.roxell@linaro.org>
>>
>> Fixes Bug 1823
>>>
>>>
>>>
>>>> ---
>>>>>   test/validation/classification/odp_classification_basic.c | 1 +
>>>>>   test/validation/classification/odp_classification_tests.c | 1 +
>>>>>   2 files changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/test/validation/classification/odp_classification_basic.c
>>>>> b/test/validation/classification/odp_classification_basic.c
>>>>> index d60eafd..c063b88 100644
>>>>> --- a/test/validation/classification/odp_classification_basic.c
>>>>> +++ b/test/validation/classification/odp_classification_basic.c
>>>>> @@ -76,6 +76,7 @@ void classification_test_cos_set_queue(void)
>>>>>          cos_queue = odp_cos_create(cosname);
>>>>>          CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
>>>>>
>>>>> +       odp_queue_param_init(&qparam);
>>>>>          qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
>>>>>          qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>>>>          qparam.sched.group = ODP_SCHED_GROUP_ALL;
>>>>> diff --git a/test/validation/classification/odp_classification_tests.c
>>>>> b/test/validation/classification/odp_classification_tests.c
>>>>> index 69a71b1..0fb624d 100644
>>>>> --- a/test/validation/classification/odp_classification_tests.c
>>>>> +++ b/test/validation/classification/odp_classification_tests.c
>>>>> @@ -408,6 +408,7 @@ void configure_cls_pmr_chain(void)
>>>>>          cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
>>>>>          CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] !=
>>>>> ODP_COS_INVALID);
>>>>>
>>>>> +       odp_queue_param_init(&qparam);
>>>>>          qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
>>>>>          qparam.sched.sync = ODP_SCHED_SYNC_NONE;
>>>>>          qparam.sched.group = ODP_SCHED_GROUP_ALL;
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>> _______________________________________________
>>>>> lng-odp mailing list
>>>>> lng-odp@lists.linaro.org
>>>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>>>
>>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>>
>>>>
>>>>
>>> --
>>> Mike Holmes
>>> Technical Manager - Linaro Networking Group
>>> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM
>>> SoCs
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>
>>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
diff mbox

Patch

diff --git a/test/validation/classification/odp_classification_basic.c b/test/validation/classification/odp_classification_basic.c
index d60eafd..c063b88 100644
--- a/test/validation/classification/odp_classification_basic.c
+++ b/test/validation/classification/odp_classification_basic.c
@@ -76,6 +76,7 @@  void classification_test_cos_set_queue(void)
 	cos_queue = odp_cos_create(cosname);
 	CU_ASSERT_FATAL(cos_queue != ODP_COS_INVALID);
 
+	odp_queue_param_init(&qparam);
 	qparam.sched.prio = ODP_SCHED_PRIO_HIGHEST;
 	qparam.sched.sync = ODP_SCHED_SYNC_NONE;
 	qparam.sched.group = ODP_SCHED_GROUP_ALL;
diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c
index 69a71b1..0fb624d 100644
--- a/test/validation/classification/odp_classification_tests.c
+++ b/test/validation/classification/odp_classification_tests.c
@@ -408,6 +408,7 @@  void configure_cls_pmr_chain(void)
 	cos_list[CLS_PMR_CHAIN_DST] = odp_cos_create(cosname);
 	CU_ASSERT_FATAL(cos_list[CLS_PMR_CHAIN_DST] != ODP_COS_INVALID);
 
+	odp_queue_param_init(&qparam);
 	qparam.sched.prio = ODP_SCHED_PRIO_NORMAL;
 	qparam.sched.sync = ODP_SCHED_SYNC_NONE;
 	qparam.sched.group = ODP_SCHED_GROUP_ALL;