| Message ID | 20220210141931.291712-3-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MediaTek pinctrl drivers cleanups | expand |
On Thu, Feb 10, 2022 at 10:20 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > As a preparation to cleanup the probe mechanism of mediatek pinctrl > drivers that are using the v1 controller, add a common probe function > to this driver. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> but > --- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 11 +++++++++++ > drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 2 ++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index 6f8dfa6ae5a0..007da39b68c9 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -1115,3 +1115,14 @@ int mtk_pctrl_init(struct platform_device *pdev, > gpiochip_remove(pctl->chip); > return ret; > } > + > +int mtk_pctrl_common_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + const struct mtk_pinctrl_devdata *data = device_get_match_data(dev); > + > + if (!data) > + return -ENOENT; This is probably bikeshedding, but it seems most other drivers use -ENODEV or -EINVAL. -ENOENT is seldomly used in this context. ChenYu
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 6f8dfa6ae5a0..007da39b68c9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -1115,3 +1115,14 @@ int mtk_pctrl_init(struct platform_device *pdev, gpiochip_remove(pctl->chip); return ret; } + +int mtk_pctrl_common_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + const struct mtk_pinctrl_devdata *data = device_get_match_data(dev); + + if (!data) + return -ENOENT; + + return mtk_pctrl_init(pdev, data, NULL); +} diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.h b/drivers/pinctrl/mediatek/pinctrl-mtk-common.h index 98f27cdc609a..cd264cc3547b 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.h +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.h @@ -277,6 +277,8 @@ int mtk_pctrl_init(struct platform_device *pdev, const struct mtk_pinctrl_devdata *data, struct regmap *regmap); +int mtk_pctrl_common_probe(struct platform_device *pdev); + int mtk_pctrl_spec_pull_set_samereg(struct regmap *regmap, const struct mtk_pin_spec_pupd_set_samereg *pupd_infos, unsigned int info_num, unsigned int pin,
As a preparation to cleanup the probe mechanism of mediatek pinctrl drivers that are using the v1 controller, add a common probe function to this driver. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 11 +++++++++++ drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 2 ++ 2 files changed, 13 insertions(+)