| Message ID | b8a94fbfcab68b1279b09b6297099310c209927b.1644198244.git.lhjeff911@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3b8ab4da3405d07ddfe434f17f9014740b30a19c |
| Headers | show |
| Series | [next] dt-bindings:spi: Fix test error for sp7021. | expand |
On 07/02/2022 02:46, Li-hao Kuo wrote: > Remove the include path and modify parameters for fix error for bt binding test 1. No trailing dots in commit title. Space after each ":". 2. s/bt/dt/ 3. Wrap the commit msg: https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L124 4. What is exactly the error you are fixing? > > Fixes: a708078eeb99 ("spi: Add Sunplus SP7021 schema") 5. Only one space after SHA. 6. Wasn't it reported to you? Looks like it was, so you need to add "Reported-by" tag: https://lore.kernel.org/all/CAL_JsqKwg_bzJmehTG8tR2cpr+HwwvpF_cpoESidZouc_SpKcQ@mail.gmail.com/ > Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> > --- > Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > index 38589fd..298eac2 100644 > --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > @@ -59,8 +59,6 @@ unevaluatedProperties: false > > examples: > - | > - #include <dt-bindings/clock/sp-sp7021.h> > - #include <dt-bindings/reset/sp-sp7021.h> > #include <dt-bindings/interrupt-controller/irq.h> > spi@9C002D80 { > compatible = "sunplus,sp7021-spi"; > @@ -73,8 +71,8 @@ examples: > interrupts = <144 IRQ_TYPE_LEVEL_HIGH>, > <146 IRQ_TYPE_LEVEL_HIGH>, > <145 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clkc SPI_COMBO_0>; > - resets = <&rstc RST_SPI_COMBO_0>; > + clocks = <&clkc 0x32>; > + resets = <&rstc 0x22>; > pinctrl-names = "default"; > pinctrl-0 = <&pins_spi0>; > }; Best regards, Krzysztof
On Sun, Feb 6, 2022 at 7:46 PM Li-hao Kuo <lhjeff911@gmail.com> wrote: > > Remove the include path and modify parameters for fix error for bt binding test > > Fixes: a708078eeb99 ("spi: Add Sunplus SP7021 schema") > Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> > --- > Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Unfortunately, this fix exposes another issue: /builds/robherring/linux-dt/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.example.dt.yaml: spi@9C002D80: 'clocks-names' is a required property
Thanks for your comment. I have sent a patch to fix it.
diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml index 38589fd..298eac2 100644 --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml @@ -59,8 +59,6 @@ unevaluatedProperties: false examples: - | - #include <dt-bindings/clock/sp-sp7021.h> - #include <dt-bindings/reset/sp-sp7021.h> #include <dt-bindings/interrupt-controller/irq.h> spi@9C002D80 { compatible = "sunplus,sp7021-spi"; @@ -73,8 +71,8 @@ examples: interrupts = <144 IRQ_TYPE_LEVEL_HIGH>, <146 IRQ_TYPE_LEVEL_HIGH>, <145 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clkc SPI_COMBO_0>; - resets = <&rstc RST_SPI_COMBO_0>; + clocks = <&clkc 0x32>; + resets = <&rstc 0x22>; pinctrl-names = "default"; pinctrl-0 = <&pins_spi0>; };
Remove the include path and modify parameters for fix error for bt binding test Fixes: a708078eeb99 ("spi: Add Sunplus SP7021 schema") Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> --- Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)