| Message ID | 1442579847-8138-1-git-send-email-guodong.xu@linaro.org |
|---|---|
| State | New |
| Headers | show
Return-Path: <patchwork-forward+bncBD36H4P6XAHBBJEL6CXQKGQER55O2LY@linaro.org> X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by patches.linaro.org (Postfix) with ESMTPS id 3D4F6218E3 for <linaro@patches.linaro.org>; Fri, 18 Sep 2015 12:37:57 +0000 (UTC) Received: by lbot4 with SMTP id t4sf16576051lbo.0 for <linaro@patches.linaro.org>; Fri, 18 Sep 2015 05:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:subject:date :message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=QUQ+FXhL+M+biYtOnFIkTm4FmzVVlgcmitYCAPoc9fM=; b=mg+xx/CvBLRTfc1QGAR6XzRtZRXMy5X+6YjWp+mN3OM8m3KUadfa/nyDr4MG5/tWB2 1PwJsj3b2nHYtguiwxV6/w9ezdYb1iXAHJNDnv6Ib+iorn5ECx639zF7vPO70LXPAIK8 eNoPreDE51M5R81+5U1H8wpzNKnGjj4R0hzCREZDe78bp5cx2e04EsDJYW68n2WTHM5d g/wRyj6DLMSBRTgxhvymwqNv6uTuMpETG9Fwfr18kZuJ03sFnIW46l5FZCBjknmBT9Zq MwpUnDU56n9rrEP/N8ay0RXlfFaPzuFGiv5de1cXGkrxED3oj2QIhRaZl0fucfVC/jyo /7Nw== X-Gm-Message-State: ALoCoQn+iw3sjU6V9dR302NH7FXOQp2Yeks4d5aiXYEOp6vcXsAGTDY9O9k9N8dBunrRocFfPmC3 X-Received: by 10.112.198.33 with SMTP id iz1mr848603lbc.8.1442579876231; Fri, 18 Sep 2015 05:37:56 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.161 with SMTP id l1ls182824lal.57.gmail; Fri, 18 Sep 2015 05:37:56 -0700 (PDT) X-Received: by 10.112.64.228 with SMTP id r4mr3080712lbs.80.1442579876070; Fri, 18 Sep 2015 05:37:56 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id i6si5883672lag.112.2015.09.18.05.37.55 for <patchwork-forward@linaro.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Sep 2015 05:37:55 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by lahg1 with SMTP id g1so29998346lah.1 for <patchwork-forward@linaro.org>; Fri, 18 Sep 2015 05:37:55 -0700 (PDT) X-Received: by 10.112.130.70 with SMTP id oc6mr3137330lbb.32.1442579875752; Fri, 18 Sep 2015 05:37:55 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp266886lbq; Fri, 18 Sep 2015 05:37:54 -0700 (PDT) X-Received: by 10.50.110.73 with SMTP id hy9mr14206390igb.8.1442579874652; Fri, 18 Sep 2015 05:37:54 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gz8si6517697igb.48.2015.09.18.05.37.54; Fri, 18 Sep 2015 05:37:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbbIRMhv (ORCPT <rfc822;pingbo.wen@linaro.org> + 30 others); Fri, 18 Sep 2015 08:37:51 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33824 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861AbbIRMht (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 18 Sep 2015 08:37:49 -0400 Received: by padhy16 with SMTP id hy16so50734523pad.1 for <linux-kernel@vger.kernel.org>; Fri, 18 Sep 2015 05:37:49 -0700 (PDT) X-Received: by 10.66.252.131 with SMTP id zs3mr6934692pac.75.1442579869283; Fri, 18 Sep 2015 05:37:49 -0700 (PDT) Received: from docularxu-ThinkPad-T440p.219.146.1.66 ([180.150.157.4]) by smtp.gmail.com with ESMTPSA id qg2sm6471022pbb.80.2015.09.18.05.37.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Sep 2015 05:37:48 -0700 (PDT) From: Guodong Xu <guodong.xu@linaro.org> To: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, eliad@wizery.com, guym@ti.com, arik@wizery.com, nsekhar@ti.com, luca@coelho.fi, ramrani@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, guodong.xu@linaro.org Subject: [PATCH] wlcore: align reg_ch_conf_last[] to 64bit Date: Fri, 18 Sep 2015 20:37:27 +0800 Message-Id: <1442579847-8138-1-git-send-email-guodong.xu@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: <patchwork-forward.linaro.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: guodong.xu@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: <http://groups.google.com/a/linaro.org/group/patchwork-forward/post>, <mailto:patchwork-forward@linaro.org> List-Help: <http://support.google.com/a/linaro.org/bin/topic.py?topic=25838>, <mailto:patchwork-forward+help@linaro.org> List-Archive: <http://groups.google.com/a/linaro.org/group/patchwork-forward/> List-Unsubscribe: <mailto:googlegroups-manage+836684582541+unsubscribe@googlegroups.com>, <http://groups.google.com/a/linaro.org/group/patchwork-forward/subscribe> |
diff --git a/drivers/net/wireless/ti/wlcore/wlcore.h b/drivers/net/wireless/ti/wlcore/wlcore.h index a1b6040..906be6a 100644 --- a/drivers/net/wireless/ti/wlcore/wlcore.h +++ b/drivers/net/wireless/ti/wlcore/wlcore.h @@ -318,7 +318,7 @@ struct wl1271 { bool watchdog_recovery; /* Reg domain last configuration */ - u32 reg_ch_conf_last[2]; + u32 reg_ch_conf_last[2] __aligned(8); /* Reg domain pending configuration */ u32 reg_ch_conf_pending[2];
Align fields reg_ch_conf_last and reg_ch_conf_pending of struct wl1271{} to 64bit. Without this, on 64bit ARM, wlcore_set_pending_regdomain_ch() fails at the point it calls set_bit(ch_bit_idx, (long*)wl->reg_ch_conf_pending); Here is the error message while doing iw wlan0 scan or connect: [ 10.666857] wlcore: IRQ work [ 10.670046] wlcore: intr: 0x40 (fw_rx_counter = 1, drv_rx_counter = 0, tx_results_counter = 0) [ 10.678697] wlcore: WL1271_ACX_INTR_DATA [ 10.682810] Unhandled fault: alignment fault (0x96000021) at 0xffffffc037a817f4 [ 10.690139] Internal error: : 96000021 [#1] PREEMPT SMP [ 10.695366] Modules linked in: [ 10.698437] CPU: 3 PID: 894 Comm: irq/60-wl18xx Tainted: G W 4.2.0-rc6-linaro-hikey #2 [ 10.707501] Hardware name: HiKey Development Board (DT) [ 10.712733] task: ffffffc03a9d1680 ti: ffffffc039e18000 task.ti: ffffffc039e18000 [ 10.720239] PC is at set_bit+0x14/0x30 [ 10.724002] LR is at wlcore_set_pending_regdomain_ch+0x40/0x4c Signed-off-by: Guodong Xu <guodong.xu@linaro.org> --- drivers/net/wireless/ti/wlcore/wlcore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)