diff mbox

[3/4,ARM] Add attribute/pragma target fpu=

Message ID 55FBCE03.4060004@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov Sept. 18, 2015, 8:40 a.m. UTC 
Hi Christian,
(going through the patches...)

On 14/09/15 12:39, Christian Bruel wrote:
> This patch splits the neon_builtins initialization into 2 internals
> functions. One for NEON and one for CRYPTO, each one guarded by its own
> predicate. arm_init_neon_builtins is now global to be called from
> arm_valid_target_attribute_tree if needed.
>
  
I don't see its relevance in this patch, and it's not mentioned in the ChangeLog.

Kyrill

Comments

Christian Bruel Sept. 18, 2015, 10:41 a.m. UTC | #1 
On 09/18/2015 10:40 AM, Kyrill Tkachov wrote:
> Hi Christian,
> (going through the patches...)
>
> On 14/09/15 12:39, Christian Bruel wrote:
>> This patch splits the neon_builtins initialization into 2 internals
>> functions. One for NEON and one for CRYPTO, each one guarded by its own
>> predicate. arm_init_neon_builtins is now global to be called from
>> arm_valid_target_attribute_tree if needed.
>>
>
> diff -ruN gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h
> --- gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h	2015-09-11 15:23:51.852687891 +0200
> +++ gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h	2015-09-11 16:30:15.833511559 +0200
> @@ -213,7 +213,10 @@
>    extern bool arm_change_mode_p (tree);
>    #endif
>
> -extern tree arm_valid_target_attribute_tree (tree, struct gcc_options *,
> +extern void arm_init_neon_builtins (void);
> +
> +extern tree arm_valid_target_attribute_tree (tree,
> +					     struct gcc_options *,
>    					     struct gcc_options *);
>
> Why the arm_valid_target_attribute_tree declaration here?
> I don't see its relevance in this patch, and it's not mentioned in the ChangeLog.

Irrelevant formating new line chunk, I must have dropped a new line in 
the argument list that percolated to the patch.

Please ignore it.

Christian
diff mbox

Patch

diff -ruN gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h
--- gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h	2015-09-11 15:23:51.852687891 +0200
+++ gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h	2015-09-11 16:30:15.833511559 +0200
@@ -213,7 +213,10 @@ 
  extern bool arm_change_mode_p (tree);
  #endif
  
-extern tree arm_valid_target_attribute_tree (tree, struct gcc_options *,
+extern void arm_init_neon_builtins (void);
+
+extern tree arm_valid_target_attribute_tree (tree,
+					     struct gcc_options *,
  					     struct gcc_options *);

Why the arm_valid_target_attribute_tree declaration here?