diff mbox series

[-next] spi: Fix compiler warning for kernel test

Message ID 1643336485-10942-1-git-send-email-lhjeff911@gmail.com
State New
Headers show
Series [-next] spi: Fix compiler warning for kernel test | expand

Commit Message

Li-hao Kuo Jan. 28, 2022, 2:21 a.m. UTC 
---
 drivers/spi/spi-sunplus-sp7021.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Mark Brown Jan. 28, 2022, 7:11 p.m. UTC | #1 
On Fri, Jan 28, 2022 at 10:47:41PM +0800, 郭力豪 wrote:
> Fix compiler warming for kernel test
> 
> Fixes: f62ca4e2a863 ("spi: Add spi driver for Sunplus SP7021")
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>

Thanks for adding the signoff but this and the other two patches you
just sent are breaking the tooling - they're sent with HMTL and it looks
like the text parts have been corrupted with at least word wrapping:

> -int sp7021_spi_slave_tx(struct spi_device *spi, struct spi_transfer *xfer)
> +static int sp7021_spi_slave_tx(struct spi_device *spi, struct spi_transfer
> *xfer)

so the diff doesn't work as-is.  Can you check and resend please, your
normal posting mechanism works fine?
diff mbox series

Patch

diff --git a/drivers/spi/spi-sunplus-sp7021.c b/drivers/spi/spi-sunplus-sp7021.c
index 627b9c3..d45b5dd 100644
--- a/drivers/spi/spi-sunplus-sp7021.c
+++ b/drivers/spi/spi-sunplus-sp7021.c
@@ -124,7 +124,7 @@  static int sp7021_spi_slave_abort(struct spi_controller *ctlr)
 	return 0;
 }
 
-int sp7021_spi_slave_tx(struct spi_device *spi, struct spi_transfer *xfer)
+static int sp7021_spi_slave_tx(struct spi_device *spi, struct spi_transfer *xfer)
 {
 	struct sp7021_spi_ctlr *pspim = spi_controller_get_devdata(spi->controller);
 
@@ -142,7 +142,7 @@  int sp7021_spi_slave_tx(struct spi_device *spi, struct spi_transfer *xfer)
 	return 0;
 }
 
-int sp7021_spi_slave_rx(struct spi_device *spi, struct spi_transfer *xfer)
+static int sp7021_spi_slave_rx(struct spi_device *spi, struct spi_transfer *xfer)
 {
 	struct sp7021_spi_ctlr *pspim = spi_controller_get_devdata(spi->controller);
 	int ret = 0;
@@ -160,7 +160,7 @@  int sp7021_spi_slave_rx(struct spi_device *spi, struct spi_transfer *xfer)
 	return ret;
 }
 
-void sp7021_spi_master_rb(struct sp7021_spi_ctlr *pspim, unsigned int len)
+static void sp7021_spi_master_rb(struct sp7021_spi_ctlr *pspim, unsigned int len)
 {
 	int i;
 
@@ -171,7 +171,7 @@  void sp7021_spi_master_rb(struct sp7021_spi_ctlr *pspim, unsigned int len)
 	}
 }
 
-void sp7021_spi_master_wb(struct sp7021_spi_ctlr *pspim, unsigned int len)
+static void sp7021_spi_master_wb(struct sp7021_spi_ctlr *pspim, unsigned int len)
 {
 	int i;
 
@@ -557,6 +557,7 @@  static int __maybe_unused sp7021_spi_controller_resume(struct device *dev)
 	return clk_prepare_enable(pspim->spi_clk);
 }
 
+#ifdef CONFIG_PM
 static int sp7021_spi_runtime_suspend(struct device *dev)
 {
 	struct spi_controller *ctlr = dev_get_drvdata(dev);
@@ -572,6 +573,7 @@  static int sp7021_spi_runtime_resume(struct device *dev)
 
 	return reset_control_deassert(pspim->rstc);
 }
+#endif
 
 static const struct dev_pm_ops sp7021_spi_pm_ops = {
 	SET_RUNTIME_PM_OPS(sp7021_spi_runtime_suspend,