Message ID | 20220127063428.30212-5-richard.henderson@linaro.org |
---|---|
State | Superseded |
Headers | show |
Series | target/arm: SVE fixes versus VHE | expand |
On Thu, 27 Jan 2022 at 06:34, Richard Henderson <richard.henderson@linaro.org> wrote: > > Use the named bit rather than a bare extract32. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index ca916139e8..5610879680 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -13034,7 +13034,7 @@ int fp_exception_el(CPUARMState *env, int cur_el) > } > > /* CPTR_EL3 : present in v8 */ > - if (extract32(env->cp15.cptr_el[3], 10, 1)) { > + if (env->cp15.cptr_el[3] & CPTR_TFP) { > /* Trap all FP ops to EL3 */ > return 3; > } > -- > 2.25.1 Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 2022/1/27 14:34, Richard Henderson wrote: > Use the named bit rather than a bare extract32. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
diff --git a/target/arm/helper.c b/target/arm/helper.c index ca916139e8..5610879680 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -13034,7 +13034,7 @@ int fp_exception_el(CPUARMState *env, int cur_el) } /* CPTR_EL3 : present in v8 */ - if (extract32(env->cp15.cptr_el[3], 10, 1)) { + if (env->cp15.cptr_el[3] & CPTR_TFP) { /* Trap all FP ops to EL3 */ return 3; }
Use the named bit rather than a bare extract32. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)