[4.4,071/114] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0

From: Kai-Heng Feng <kai.heng.feng@canonical.com>

From: Kai-Heng Feng <kai.heng.feng@canonical.com>

[ Upstream commit 00558586382891540c59c9febc671062425a6e47 ]

When a new USB device gets plugged to nested hubs, the affected hub,
which connects to usb 2-1.4-port2, doesn't report there's any change,
hence the nested hubs go back to runtime suspend like nothing happened:
[  281.032951] usb usb2: usb wakeup-resume
[  281.032959] usb usb2: usb auto-resume
[  281.032974] hub 2-0:1.0: hub_resume
[  281.033011] usb usb2-port1: status 0263 change 0000
[  281.033077] hub 2-0:1.0: state 7 ports 4 chg 0000 evt 0000
[  281.049797] usb 2-1: usb wakeup-resume
[  281.069800] usb 2-1: Waited 0ms for CONNECT
[  281.069810] usb 2-1: finish resume
[  281.070026] hub 2-1:1.0: hub_resume
[  281.070250] usb 2-1-port4: status 0203 change 0000
[  281.070272] usb usb2-port1: resume, status 0
[  281.070282] hub 2-1:1.0: state 7 ports 4 chg 0010 evt 0000
[  281.089813] usb 2-1.4: usb wakeup-resume
[  281.109792] usb 2-1.4: Waited 0ms for CONNECT
[  281.109801] usb 2-1.4: finish resume
[  281.109991] hub 2-1.4:1.0: hub_resume
[  281.110147] usb 2-1.4-port2: status 0263 change 0000
[  281.110234] usb 2-1-port4: resume, status 0
[  281.110239] usb 2-1-port4: status 0203, change 0000, 10.0 Gb/s
[  281.110266] hub 2-1.4:1.0: state 7 ports 4 chg 0000 evt 0000
[  281.110426] hub 2-1.4:1.0: hub_suspend
[  281.110565] usb 2-1.4: usb auto-suspend, wakeup 1
[  281.130998] hub 2-1:1.0: hub_suspend
[  281.137788] usb 2-1: usb auto-suspend, wakeup 1
[  281.142935] hub 2-0:1.0: state 7 ports 4 chg 0000 evt 0000
[  281.177828] usb 2-1: usb wakeup-resume
[  281.197839] usb 2-1: Waited 0ms for CONNECT
[  281.197850] usb 2-1: finish resume
[  281.197984] hub 2-1:1.0: hub_resume
[  281.198203] usb 2-1-port4: status 0203 change 0000
[  281.198228] usb usb2-port1: resume, status 0
[  281.198237] hub 2-1:1.0: state 7 ports 4 chg 0010 evt 0000
[  281.217835] usb 2-1.4: usb wakeup-resume
[  281.237834] usb 2-1.4: Waited 0ms for CONNECT
[  281.237845] usb 2-1.4: finish resume
[  281.237990] hub 2-1.4:1.0: hub_resume
[  281.238067] usb 2-1.4-port2: status 0263 change 0000
[  281.238148] usb 2-1-port4: resume, status 0
[  281.238152] usb 2-1-port4: status 0203, change 0000, 10.0 Gb/s
[  281.238166] hub 2-1.4:1.0: state 7 ports 4 chg 0000 evt 0000
[  281.238385] hub 2-1.4:1.0: hub_suspend
[  281.238523] usb 2-1.4: usb auto-suspend, wakeup 1
[  281.258076] hub 2-1:1.0: hub_suspend
[  281.265744] usb 2-1: usb auto-suspend, wakeup 1
[  281.285976] hub 2-0:1.0: hub_suspend
[  281.285988] usb usb2: bus auto-suspend, wakeup 1

USB 3.2 spec, 9.2.5.4 "Changing Function Suspend State" says that "If
the link is in a non-U0 state, then the device must transition the link
to U0 prior to sending the remote wake message", but the hub only
transits the link to U0 after signaling remote wakeup.

So be more forgiving and use a 20ms delay to let the link transit to U0
for remote wakeup.

Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20211215120108.336597-1-kai.heng.feng@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/usb/core/hub.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Message ID	20220124183929.289646365@linuxfoundation.org
State	New
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>, Kai-Heng Feng <kai.heng.feng@canonical.com>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 4.4 071/114] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0 Date: Mon, 24 Jan 2022 19:42:46 +0100 Message-Id: <20220124183929.289646365@linuxfoundation.org> In-Reply-To: <20220124183927.095545464@linuxfoundation.org> References: <20220124183927.095545464@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [4.4,002/114] USB: core: Fix bug in resuming hubs handling of wakeup requests [4.4,004/114] mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe() [4.4,006/114] can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} [4.4,008/114] media: uvcvideo: fix division by zero at stream start [4.4,010/114] HID: uhid: Fix worker destroying device without any protection [4.4,014/114] media: em28xx: fix control-message timeouts [4.4,016/114] media: pvrusb2: fix control-message timeouts [4.4,017/114] media: stk1160: fix control-message timeouts [4.4,020/114] Bluetooth: cmtp: fix possible panic when cmtp_init_sockets() fails [4.4,022/114] crypto: qce - fix uaf on qce_ahash_register_one [4.4,024/114] tty: serial: atmel: Call dma_async_issue_pending() [4.4,026/114] arm64: dts: qcom: msm8916: fix MMC controller aliases [4.4,027/114] drm/amdgpu: Fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode() [4.4,030/114] media: dib8000: Fix a memleak in dib8000_init() [4.4,032/114] media: msi001: fix possible null-ptr-deref in msi001_probe() [4.4,037/114] spi: spi-meson-spifc: Add missing pm_runtime_disable() in meson_spifc_probe [4.4,038/114] can: softing: softing_startstop(): fix set but not used variable warning [4.4,039/114] can: xilinx_can: xcan_probe(): check for error irq [4.4,041/114] net: mcs7830: handle usb read errors properly [4.4,043/114] ALSA: jack: Add missing rwsem around snd_ctl_remove() calls [4.4,045/114] ALSA: hda: Add missing rwsem around snd_ctl_remove() calls [4.4,046/114] powerpc/prom_init: Fix improper check of prom_getprop() [4.4,050/114] RDMA/core: Let ib_find_gid() continue search even after empty entry [4.4,053/114] misc: lattice-ecp3-config: Fix task hung when firmware load failed [4.4,054/114] mips: lantiq: add support for clk_set_parent() [4.4,055/114] mips: bcm63xx: add support for clk_set_parent() [4.4,057/114] Bluetooth: Fix debugfs entry leak in hci_register_dev() [4.4,058/114] fs: dlm: filter user dlm messages for kernel locks [4.4,059/114] ar5523: Fix null-ptr-deref with unexpected WDCMSG_TARGET_START reply [4.4,062/114] HSI: core: Fix return freed object in hsi_new_client [4.4,063/114] mwifiex: Fix skb_over_panic in mwifiex_usb_recv() [4.4,064/114] floppy: Add max size check for user space request [4.4,065/114] media: saa7146: hexium_orion: Fix a NULL pointer dereference in hexium_attach() [4.4,070/114] media: saa7146: hexium_gemini: Fix a NULL pointer dereference in hexium_attach() [4.4,071/114] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0 [4.4,074/114] ACPICA: Utilities: Avoid deleting the same object twice in a row [4.4,075/114] ACPICA: Executer: Fix the REFCLASS_REFOF case in acpi_ex_opcode_1A_0T_1R() [4.4,077/114] btrfs: remove BUG_ON(!eie) in find_parent_nodes [4.4,080/114] dm space map common: add bounds check to sm_ll_lookup_bitmap() [4.4,081/114] serial: pl010: Drop CR register reset on set_termios [4.4,083/114] parisc: Avoid calling faulthandler_disabled() twice [4.4,084/114] powerpc/6xx: add missing of_node_put [4.4,088/114] i2c: i801: Dont silently correct invalid transfer size [4.4,091/114] w1: Misuse of get_user()/put_user() reported by sparse [4.4,094/114] MIPS: Octeon: Fix build errors using clang [4.4,095/114] scsi: sr: Dont use GFP_DMA [4.4,097/114] ubifs: Error path in ubifs_remount_rw() seems to wrongly free write buffers [4.4,099/114] ext4: Fix BUG_ON in ext4_bread when write quota data [4.4,102/114] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module [4.4,103/114] parisc: pdc_stable: Fix memory leak in pdcs_register_pathentries [4.4,105/114] net: axienet: Wait for PhyRstCmplt after core reset [4.4,107/114] netns: add schedule point in ops_exit_list() [4.4,112/114] net_sched: restore "mpu xxx" handling [4.4,113/114] bcmgenet: add WOL IRQ check [4.4,114/114] lib82596: Fix IRQ check in sni_82596_probe

[4.4,071/114] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0

Commit Message

Patch