diff mbox series

[V2,06/10] selftests: landlock: Add the uapi headers include variable

Message ID 20220119101531.2850400-7-usama.anjum@collabora.com
State Accepted
Commit cb542c66f304c85c19eb07a88dded326e5bfcfe5
Headers show
Series selftests: Fix separate output directory builds | expand

Commit Message

Muhammad Usama Anjum Jan. 19, 2022, 10:15 a.m. UTC
Out of tree build of this test fails if relative path of the output
directory is specified. Add the KHDR_INCLUDES to correctly reach the
headers.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
Changes in V2:
        Revert the excessive cleanup which was breaking the individual
test build.
---
 tools/testing/selftests/landlock/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mickaël Salaün Jan. 20, 2022, 6:20 p.m. UTC | #1
On 19/01/2022 11:15, Muhammad Usama Anjum wrote:
> Out of tree build of this test fails if relative path of the output
> directory is specified. Add the KHDR_INCLUDES to correctly reach the
> headers.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in V2:
>          Revert the excessive cleanup which was breaking the individual
> test build.
> ---
>   tools/testing/selftests/landlock/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
> index a99596ca9882..0b0049e133bb 100644
> --- a/tools/testing/selftests/landlock/Makefile
> +++ b/tools/testing/selftests/landlock/Makefile
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   
> -CFLAGS += -Wall -O2
> +CFLAGS += -Wall -O2 $(KHDR_INCLUDES)

Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>

It works for me, but I'm wondering if a missing -I path could cause any 
issue (cf. -I$(khdr_dir) bellow in this file). My GCC and clang ignore 
such non-existent paths unless -Wmissing-include-dirs is used, which 
would print a warning on your CI, but I guess that's OK.

>   
>   src_test := $(wildcard *_test.c)
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
index a99596ca9882..0b0049e133bb 100644
--- a/tools/testing/selftests/landlock/Makefile
+++ b/tools/testing/selftests/landlock/Makefile
@@ -1,6 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0
 
-CFLAGS += -Wall -O2
+CFLAGS += -Wall -O2 $(KHDR_INCLUDES)
 
 src_test := $(wildcard *_test.c)