| Message ID | 1441634692-19494-7-git-send-email-bamvor.zhangjian@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > selftests: exec: simpification the Makefile Please give us a better subject, ie something like: selftests/exec: Revert to default emit rule > With the previous patch, the installation method change from install > to rsync. There is not no need to create subdir during test, the ^ one too many "not" > default RUN_TESTS is enough. ^ EMIT_TESTS > > This patch implicitly revert commit 84cbd9e4 ("selftests/exec: do not ^ "essentially" would be more accurate I think > install subdir as it is already created"). cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile index 6b76bfd..4e400eb 100644 --- a/tools/testing/selftests/exec/Makefile +++ b/tools/testing/selftests/exec/Makefile @@ -1,6 +1,6 @@ CFLAGS = -Wall BINARIES = execveat -DEPS = execveat.symlink execveat.denatured script +DEPS = execveat.symlink execveat.denatured script subdir all: $(BINARIES) $(DEPS) subdir: @@ -22,7 +22,5 @@ TEST_FILES := $(DEPS) include ../lib.mk -override EMIT_TESTS := echo "mkdir -p subdir; (./execveat && echo \"selftests: execveat [PASS]\") || echo \"selftests: execveat [FAIL]\"" - clean: rm -rf $(BINARIES) $(DEPS) subdir.moved execveat.moved xxxxx*
With the previous patch, the installation method change from install to rsync. There is not no need to create subdir during test, the default RUN_TESTS is enough. This patch implicitly revert commit 84cbd9e4 ("selftests/exec: do not install subdir as it is already created"). Suggested-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> --- tools/testing/selftests/exec/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)