| Message ID | 20220115100444.3014823-1-clabbe@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] ARM: dts: gemini: ns2502: permit to use gigabit | expand |
On Sat, Jan 15, 2022 at 11:04 AM Corentin Labbe <clabbe@baylibre.com> wrote: > I believed that gigabit was not working due to some unknown missing GPIO. > In fact, gigabit worked when REALTEK_PHY was compiled out. > So the problem was due to PHY delay and we need to use rgmii-id. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Thanks Corentin! Patches applied. Do you think I need a similar fix "rgmii"->"rgmii-id" on other Gemini devicetrees that claim gigabit performance? Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/gemini-ns2502.dts b/arch/arm/boot/dts/gemini-ns2502.dts index 37e5debb693c..c759c4c732ab 100644 --- a/arch/arm/boot/dts/gemini-ns2502.dts +++ b/arch/arm/boot/dts/gemini-ns2502.dts @@ -39,10 +39,6 @@ mdio0: mdio { phy0: ethernet-phy@1 { reg = <1>; device_type = "ethernet-phy"; - /* We lack the knowledge of necessary GPIO to achieve - * Gigabit - */ - max-speed = <100>; }; }; }; @@ -50,7 +46,7 @@ phy0: ethernet-phy@1 { ðernet { status = "okay"; ethernet-port@0 { - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&phy0>; mac-address = [00 1F 1F 8E 65 E2]; };
I believed that gigabit was not working due to some unknown missing GPIO. In fact, gigabit worked when REALTEK_PHY was compiled out. So the problem was due to PHY delay and we need to use rgmii-id. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- arch/arm/boot/dts/gemini-ns2502.dts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)