| Message ID | 20220111201722.327219-21-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Tue, 11 Jan 2022 at 22:19, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Older Samsung Exynos SoC pin controller nodes (Exynos3250, Exynos4, > Exynos5, Exynos5433) with external wake-up interrupts, expected to have > one interrupt for multiplexing these wake-up interrupts. Also they > expected to have exactly one pin controller capable of external wake-up > interrupts. > > It seems however that newer ARMv8 Exynos SoC like Exynos850 and > ExynosAutov9 have differences: > 1. No multiplexed external wake-up interrupt, only direct, > 2. More than one pin controller capable of external wake-up interrupts. > > Use dedicated Exynos850 compatible for its external wake-up interrupts > controller to indicate the differences. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > arch/arm64/boot/dts/exynos/exynos850.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > index 4f0a40de5e67..bcae772e8d91 100644 > --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > @@ -346,7 +346,7 @@ pinctrl_alive: pinctrl@11850000 { > reg = <0x11850000 0x1000>; > > wakeup-interrupt-controller { > - compatible = "samsung,exynos7-wakeup-eint"; > + compatible = "samsung,exynos850-wakeup-eint"; > }; > }; > > @@ -355,7 +355,7 @@ pinctrl_cmgp: pinctrl@11c30000 { > reg = <0x11c30000 0x1000>; > > wakeup-interrupt-controller { > - compatible = "samsung,exynos7-wakeup-eint"; > + compatible = "samsung,exynos850-wakeup-eint"; > }; > }; > > -- > 2.32.0 >
diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index 4f0a40de5e67..bcae772e8d91 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -346,7 +346,7 @@ pinctrl_alive: pinctrl@11850000 { reg = <0x11850000 0x1000>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynos850-wakeup-eint"; }; }; @@ -355,7 +355,7 @@ pinctrl_cmgp: pinctrl@11c30000 { reg = <0x11c30000 0x1000>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynos850-wakeup-eint"; }; };
Older Samsung Exynos SoC pin controller nodes (Exynos3250, Exynos4, Exynos5, Exynos5433) with external wake-up interrupts, expected to have one interrupt for multiplexing these wake-up interrupts. Also they expected to have exactly one pin controller capable of external wake-up interrupts. It seems however that newer ARMv8 Exynos SoC like Exynos850 and ExynosAutov9 have differences: 1. No multiplexed external wake-up interrupt, only direct, 2. More than one pin controller capable of external wake-up interrupts. Use dedicated Exynos850 compatible for its external wake-up interrupts controller to indicate the differences. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)