| Message ID | 20220111172655.3546766-1-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ | expand |
On 2022/1/12 1:26, Peter Maydell wrote: > Fix a comment in qdev-core.h where we incorrectly referred > to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index d19c9417520..92c3d652086 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n); > * qemu_irqs at once, or to connect multiple outbound GPIOs to the > * same qemu_irq. (Warning: there is no assertion or other guard to > * catch this error: the model will just not do the right thing.) > - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect > + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect > * a device's outbound GPIO to the splitter's input, and connect each > * of the splitter's outputs to a different device. For fan-in you > * can use the TYPE_OR_IRQ device, which is a model of a logical OR Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Le 11/01/2022 à 18:26, Peter Maydell a écrit : > Fix a comment in qdev-core.h where we incorrectly referred > to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index d19c9417520..92c3d652086 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n); > * qemu_irqs at once, or to connect multiple outbound GPIOs to the > * same qemu_irq. (Warning: there is no assertion or other guard to > * catch this error: the model will just not do the right thing.) > - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect > + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect > * a device's outbound GPIO to the splitter's input, and connect each > * of the splitter's outputs to a different device. For fan-in you > * can use the TYPE_OR_IRQ device, which is a model of a logical OR Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index d19c9417520..92c3d652086 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n); * qemu_irqs at once, or to connect multiple outbound GPIOs to the * same qemu_irq. (Warning: there is no assertion or other guard to * catch this error: the model will just not do the right thing.) - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect * a device's outbound GPIO to the splitter's input, and connect each * of the splitter's outputs to a different device. For fan-in you * can use the TYPE_OR_IRQ device, which is a model of a logical OR
Fix a comment in qdev-core.h where we incorrectly referred to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)