diff mbox

[PATCHv2,1/8] linux-generic: schedule: correct schedule group handling

Message ID 1441293400-28777-2-git-send-email-bill.fischofer@linaro.org
State Accepted
Commit 57ab1d5316774c1befc201af9fae017bd2ad5965
Headers show

Commit Message

Bill Fischofer Sept. 3, 2015, 3:16 p.m. UTC 
Correct the range check on odp_schedule_group_destroy() and the
associated handling of scheduler group names.

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 platform/linux-generic/odp_schedule.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c
index dc2d75f..d2543ad 100644
--- a/platform/linux-generic/odp_schedule.c
+++ b/platform/linux-generic/odp_schedule.c
@@ -178,7 +178,7 @@  int odp_schedule_init_global(void)
 	odp_spinlock_init(&sched->grp_lock);
 
 	for (i = 0; i < ODP_CONFIG_SCHED_GRPS; i++) {
-		memset(&sched->sched_grp[i].name, 0, ODP_SCHED_GROUP_NAME_LEN);
+		memset(sched->sched_grp[i].name, 0, ODP_SCHED_GROUP_NAME_LEN);
 		sched->sched_grp[i].mask = thread_sched_grp_mask(i);
 	}
 
@@ -685,10 +685,10 @@  int odp_schedule_group_destroy(odp_schedule_group_t group)
 	odp_spinlock_lock(&sched->grp_lock);
 
 	if (group < ODP_CONFIG_SCHED_GRPS &&
-	    group > _ODP_SCHED_GROUP_NAMED &&
+	    group >= _ODP_SCHED_GROUP_NAMED &&
 	    sched->sched_grp[group].name[0] != 0) {
 		odp_thrmask_zero(sched->sched_grp[group].mask);
-		memset(&sched->sched_grp[group].name, 0,
+		memset(sched->sched_grp[group].name, 0,
 		       ODP_SCHED_GROUP_NAME_LEN);
 		ret = 0;
 	} else {