diff mbox series

scsi: hisi_sas: Remove unused variable and check in hisi_sas_send_ata_reset_each_phy()

Message ID 1641300126-53574-1-git-send-email-chenxiang66@hisilicon.com
State New
Headers show
Series scsi: hisi_sas: Remove unused variable and check in hisi_sas_send_ata_reset_each_phy() | expand

Commit Message

chenxiang Jan. 4, 2022, 12:42 p.m. UTC 
From: Xiang Chen <chenxiang66@hisilicon.com>

In commit 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to
asd_sas_port->phy_list"), we use asd_sas_port->phy_mask instead of
accessing asd_sas_port->phy_list, and it is enough to use
asd_sas_port->phy_mask to check the state of phy, so remove the unused
check and variable.

Fixes: 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to asd_sas_port->phy_list")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: Colin King <colin.i.king@gmail.com>
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

John Garry Jan. 5, 2022, 9:06 a.m. UTC | #1 
On 04/01/2022 12:42, chenxiang wrote:
> From: Xiang Chen<chenxiang66@hisilicon.com>
> 
> In commit 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to
> asd_sas_port->phy_list"), we use asd_sas_port->phy_mask instead of
> accessing asd_sas_port->phy_list, and it is enough to use
> asd_sas_port->phy_mask to check the state of phy, so remove the unused
> check and variable.
> 
> Fixes: 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to asd_sas_port->phy_list")
> Reported-by: Nathan Chancellor<nathan@kernel.org>
> Reported-by: Colin King<colin.i.king@gmail.com>
> Signed-off-by: Xiang Chen<chenxiang66@hisilicon.com>

Acked-by: John Garry <john.garry@huawei.com>
Martin K. Petersen Jan. 7, 2022, 2:09 p.m. UTC | #2 
chenxiang,

> In commit 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to
> asd_sas_port->phy_list"), we use asd_sas_port->phy_mask instead of
> accessing asd_sas_port->phy_list, and it is enough to use
> asd_sas_port->phy_mask to check the state of phy, so remove the unused
> check and variable.

Applied to 5.17/scsi-staging, thanks!
Martin K. Petersen Jan. 10, 2022, 10:04 p.m. UTC | #3 
On Tue, 4 Jan 2022 20:42:06 +0800, chenxiang wrote:

> From: Xiang Chen <chenxiang66@hisilicon.com>
> 
> In commit 29e2bac87421 ("scsi: hisi_sas: Fix some issues related to
> asd_sas_port->phy_list"), we use asd_sas_port->phy_mask instead of
> accessing asd_sas_port->phy_list, and it is enough to use
> asd_sas_port->phy_mask to check the state of phy, so remove the unused
> check and variable.
> 
> [...]

Applied to 5.17/scsi-queue, thanks!

[1/1] scsi: hisi_sas: Remove unused variable and check in hisi_sas_send_ata_reset_each_phy()
      https://git.kernel.org/mkp/scsi/c/5d9224fb076e
diff mbox series

Patch

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f46f679fe825..a05ec7aece5a 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1525,16 +1525,11 @@  static void hisi_sas_send_ata_reset_each_phy(struct hisi_hba *hisi_hba,
 	struct device *dev = hisi_hba->dev;
 	int s = sizeof(struct host_to_dev_fis);
 	int rc = TMF_RESP_FUNC_FAILED;
-	struct asd_sas_phy *sas_phy;
 	struct ata_link *link;
 	u8 fis[20] = {0};
-	u32 state;
 	int i;
 
-	state = hisi_hba->hw->get_phys_state(hisi_hba);
 	for (i = 0; i < hisi_hba->n_phy; i++) {
-		if (!(state & BIT(sas_phy->id)))
-			continue;
 		if (!(sas_port->phy_mask & BIT(i)))
 			continue;