| Message ID | 1441137616-2970-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | e3d1361c157b991ea9844b23c211c82e5c9b8408 |
| Headers | show |
On Tue, Sep 1, 2015 at 3:00 PM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > schedule test can hang deadlock in due to missing spin unlock. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > platform/linux-generic/odp_queue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/platform/linux-generic/odp_queue.c > b/platform/linux-generic/odp_queue.c > index 1bd0de6..bc59d88 100644 > --- a/platform/linux-generic/odp_queue.c > +++ b/platform/linux-generic/odp_queue.c > @@ -941,6 +941,7 @@ int release_order(queue_entry_t *origin_qe, uint64_t > order, > > if (reorder_buf && reorder_buf->order == order) { > reorder_buf->flags.sustain = 0; > + UNLOCK(&origin_qe->s.lock); > return 0; > } > } > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 09/01/15 23:01, Bill Fischofer wrote: > > > On Tue, Sep 1, 2015 at 3:00 PM, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > schedule test can hang deadlock in due to missing spin unlock. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > > > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > --- > platform/linux-generic/odp_queue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/platform/linux-generic/odp_queue.c > b/platform/linux-generic/odp_queue.c > index 1bd0de6..bc59d88 100644 > --- a/platform/linux-generic/odp_queue.c > +++ b/platform/linux-generic/odp_queue.c > @@ -941,6 +941,7 @@ int release_order(queue_entry_t *origin_qe, > uint64_t order, > > if (reorder_buf && reorder_buf->order == order) { > reorder_buf->flags.sustain = 0; > + UNLOCK(&origin_qe->s.lock); > return 0; > } > } > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > >
diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 1bd0de6..bc59d88 100644 --- a/platform/linux-generic/odp_queue.c +++ b/platform/linux-generic/odp_queue.c @@ -941,6 +941,7 @@ int release_order(queue_entry_t *origin_qe, uint64_t order, if (reorder_buf && reorder_buf->order == order) { reorder_buf->flags.sustain = 0; + UNLOCK(&origin_qe->s.lock); return 0; } }
schedule test can hang deadlock in due to missing spin unlock. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- platform/linux-generic/odp_queue.c | 1 + 1 file changed, 1 insertion(+)