| Message ID | 1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > Return value would give clear information about the actual root-cause > of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message. > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c [] > @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) > > ret = sdhci_add_host(host); > if (ret) { > - dev_err(&pdev->dev, "failed to add host\n"); > + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); > goto err_add_host; > } > If this is really desirable, there are many other callers of sdhci_add_host with error messages just like this one. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: >> Return value would give clear information about the actual root-cause >> of the failure. > > I'm not sure why that is as nearly every error path in > sdhci_add_host emits a message. > Not for everything. No error message for -EPROBE_DEFER. >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > [] >> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) >> >> ret = sdhci_add_host(host); >> if (ret) { >> - dev_err(&pdev->dev, "failed to add host\n"); >> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); >> goto err_add_host; >> } >> > > If this is really desirable, there are many other callers of > sdhci_add_host with error messages just like this one. > Yes, true. Ho about, adding pr_err into sdhci_add_host for -EPROBE_DEFER. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index d02bc37..5d26fe0 100644 --- a/drivers/mmc/host/sdhci-pxav3.c +++ b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) ret = sdhci_add_host(host); if (ret) { - dev_err(&pdev->dev, "failed to add host\n"); + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); goto err_add_host; }
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)