| Message ID | 20211223175005.52976-1-nicolas.fella@gmx.de |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ] Use audio-card-bluetooth icon | expand |
Hi Nicolas, On Fri, Dec 24, 2021 at 5:06 PM Nicolas Fella <nicolas.fella@gmx.de> wrote: > > PulseAudio uses this icon for this kind of device > > Let's be consistent > > Users will gracefully fall back to audio-card if audio-card-bluetooth > is not found > --- > src/dbus-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dbus-common.c b/src/dbus-common.c > index 5e2c83d52..3611cb013 100644 > --- a/src/dbus-common.c > +++ b/src/dbus-common.c > @@ -80,7 +80,7 @@ const char *class_to_icon(uint32_t class) > case 0x0d: /* Camcorder */ > return "camera-video"; > default: > - return "audio-card"; /* Other audio device */ > + return "audio-card-bluetooth"; /* Other audio device */ > } > break; > case 0x05: > -- > 2.34.1 It doesn't seem to be part of https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html, does the icon themes really have such icon?
Hi On 1/5/22 20:07, Luiz Augusto von Dentz wrote: > Hi Nicolas, > > On Fri, Dec 24, 2021 at 5:06 PM Nicolas Fella <nicolas.fella@gmx.de> wrote: >> PulseAudio uses this icon for this kind of device >> >> Let's be consistent >> >> Users will gracefully fall back to audio-card if audio-card-bluetooth >> is not found >> --- >> src/dbus-common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/dbus-common.c b/src/dbus-common.c >> index 5e2c83d52..3611cb013 100644 >> --- a/src/dbus-common.c >> +++ b/src/dbus-common.c >> @@ -80,7 +80,7 @@ const char *class_to_icon(uint32_t class) >> case 0x0d: /* Camcorder */ >> return "camera-video"; >> default: >> - return "audio-card"; /* Other audio device */ >> + return "audio-card-bluetooth"; /* Other audio device */ >> } >> break; >> case 0x05: >> -- >> 2.34.1 > It doesn't seem to be part of > https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html, > does the icon themes really have such icon? I can't name any theme that does. There is a request to add it to Breeze in https://bugs.kde.org/show_bug.cgi?id=447431. If a theme doesn't have audio-card-bluetooth a compliant implementation will fall back to audio-card, so using it won't hurt. We have a bit of a chicken-and-egg situation here. Without bluez using the icon there is less incentive to add it to icon themes. Cheers Nicolas
diff --git a/src/dbus-common.c b/src/dbus-common.c index 5e2c83d52..3611cb013 100644 --- a/src/dbus-common.c +++ b/src/dbus-common.c @@ -80,7 +80,7 @@ const char *class_to_icon(uint32_t class) case 0x0d: /* Camcorder */ return "camera-video"; default: - return "audio-card"; /* Other audio device */ + return "audio-card-bluetooth"; /* Other audio device */ } break; case 0x05: