| Message ID | 20211224025318.1541232-1-jiasheng@iscas.ac.cn |
|---|---|
| State | Accepted |
| Commit | b38cd3b42fba66cc538edb9cf77e07881f43f8e2 |
| Headers | show |
| Series | Bluetooth: hci_bcm: Check for error irq | expand |
Hi Jiasheng, > For the possible failure of the platform_get_irq(), the returned irq > could be error number and will finally cause the failure of the > request_irq(). > Consider that platform_get_irq() can now in certain cases return > -EPROBE_DEFER, and the consequences of letting request_irq() effectively > convert that into -EINVAL, even at probe time rather than later on. > So it might be better to check just now. > > Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/bluetooth/hci_bcm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 3cd57fc56ade..3f939fe89998 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -1182,7 +1182,12 @@ static int bcm_probe(struct platform_device *pdev) return -ENOMEM; dev->dev = &pdev->dev; - dev->irq = platform_get_irq(pdev, 0); + + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + dev->irq = ret; /* Initialize routing field to an unused value */ dev->pcm_int_params[0] = 0xff;
For the possible failure of the platform_get_irq(), the returned irq could be error number and will finally cause the failure of the request_irq(). Consider that platform_get_irq() can now in certain cases return -EPROBE_DEFER, and the consequences of letting request_irq() effectively convert that into -EINVAL, even at probe time rather than later on. So it might be better to check just now. Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/bluetooth/hci_bcm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)