| Message ID | 20211208174158.114122-1-amhamza.mgc@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: uvcvideo: fix possible memory leak issue | expand |
diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index f4e4aff8ddf7..711556d13d03 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -44,8 +44,10 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *chain, if (v4l2_ctrl_get_name(map->id) == NULL) { map->name = kmemdup(xmap->name, sizeof(xmap->name), GFP_KERNEL); - if (!map->name) - return -ENOMEM; + if (!map->name) { + ret = -ENOMEM; + goto free_map; + } } memcpy(map->entity, xmap->entity, sizeof(map->entity)); map->selector = xmap->selector;
In uvc_ioctl_ctrl_map() implementation, there is a possibility of memory leak if control id name is not listed and kmemdup() is failed somehow. This is a rare scenario but possible. Addresses-Coverity: 1494069 (Resource leak) Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com> --- drivers/media/usb/uvc/uvc_v4l2.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)