diff mbox series

[net,1/9] can: pch_can: pch_can_rx_normal: fix use after free

Message ID 20211207102420.120131-2-mkl@pengutronix.de
State Accepted
Commit 94cddf1e9227a171b27292509d59691819c458db
Headers show
Series [net,1/9] can: pch_can: pch_can_rx_normal: fix use after free | expand

Commit Message

Marc Kleine-Budde Dec. 7, 2021, 10:24 a.m. UTC 
From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

After calling netif_receive_skb(skb), dereferencing skb is unsafe.
Especially, the can_frame cf which aliases skb memory is dereferenced
just after the call netif_receive_skb(skb).

Reordering the lines solves the issue.

Fixes: b21d18b51b31 ("can: Topcliff: Add PCH_CAN driver.")
Link: https://lore.kernel.org/all/20211123111654.621610-1-mailhol.vincent@wanadoo.fr
Cc: stable@vger.kernel.org
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/pch_can.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 4dbb0dad8e63fcd0b5a117c2861d2abe7ff5f186
diff mbox series

Patch

diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 92a54a5fd4c5..964c8a09226a 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -692,11 +692,11 @@  static int pch_can_rx_normal(struct net_device *ndev, u32 obj_num, int quota)
 			cf->data[i + 1] = data_reg >> 8;
 		}
 
-		netif_receive_skb(skb);
 		rcv_pkts++;
 		stats->rx_packets++;
 		quota--;
 		stats->rx_bytes += cf->len;
+		netif_receive_skb(skb);
 
 		pch_fifo_thresh(priv, obj_num);
 		obj_num++;