diff mbox series

[v2,RESEND,7/8] arm: dts: exynos: Rename hsi2c nodes to i2c for Exynos5260

Message ID 20211204215820.17378-8-semen.protsenko@linaro.org
State Accepted
Commit 29bf0ff5ae18ad1a6dd183569cc097e578052c57
Headers show
Series None | expand

Commit Message

Sam Protsenko Dec. 4, 2021, 9:58 p.m. UTC
In Device Tree specification it's recommended to use "i2c" name for I2C
nodes. Now that i2c-exynos5 dt-schema binding was added, it shows some
warnings like this when validating HS-I2C nodes:

    hsi2c@xxxxxxxxx: $nodename:0: 'hsi2c@xxxxxxxx' does not match
                                  '^i2c(@.*)?'
    From schema: Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml

Rename hsi2c@* to i2c@* to fix those warnings.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2:
  - This patch was added in v2

 arch/arm/boot/dts/exynos5260.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Wolfram Sang Dec. 9, 2021, 2:48 p.m. UTC | #1
On Sat, Dec 04, 2021 at 11:58:19PM +0200, Sam Protsenko wrote:
> In Device Tree specification it's recommended to use "i2c" name for I2C
> nodes. Now that i2c-exynos5 dt-schema binding was added, it shows some
> warnings like this when validating HS-I2C nodes:
> 
>     hsi2c@xxxxxxxxx: $nodename:0: 'hsi2c@xxxxxxxx' does not match
>                                   '^i2c(@.*)?'
>     From schema: Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> 
> Rename hsi2c@* to i2c@* to fix those warnings.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Applied to for-next, thanks!
Sam Protsenko Dec. 9, 2021, 3:22 p.m. UTC | #2
On Thu, 9 Dec 2021 at 16:49, Wolfram Sang <wsa@kernel.org> wrote:
>
> On Sat, Dec 04, 2021 at 11:58:19PM +0200, Sam Protsenko wrote:
> > In Device Tree specification it's recommended to use "i2c" name for I2C
> > nodes. Now that i2c-exynos5 dt-schema binding was added, it shows some
> > warnings like this when validating HS-I2C nodes:
> >
> >     hsi2c@xxxxxxxxx: $nodename:0: 'hsi2c@xxxxxxxx' does not match
> >                                   '^i2c(@.*)?'
> >     From schema: Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> >
> > Rename hsi2c@* to i2c@* to fix those warnings.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Applied to for-next, thanks!
>

Just a heads up: Krzysztof has already taken patches #7 and #8 to his
tree: [1]. Other than that, thanks a lot for handling this series!

[1] https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-next
Krzysztof Kozlowski Dec. 9, 2021, 6:26 p.m. UTC | #3
On 09/12/2021 15:48, Wolfram Sang wrote:
> On Sat, Dec 04, 2021 at 11:58:19PM +0200, Sam Protsenko wrote:
>> In Device Tree specification it's recommended to use "i2c" name for I2C
>> nodes. Now that i2c-exynos5 dt-schema binding was added, it shows some
>> warnings like this when validating HS-I2C nodes:
>>
>>     hsi2c@xxxxxxxxx: $nodename:0: 'hsi2c@xxxxxxxx' does not match
>>                                   '^i2c(@.*)?'
>>     From schema: Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
>>
>> Rename hsi2c@* to i2c@* to fix those warnings.
>>
>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> 
> Applied to for-next, thanks!

I applied the DTS patches, because they should go via arm-soc tree.
Please drop them from I2C.

Best regards,
Krzysztof
Wolfram Sang Dec. 9, 2021, 6:52 p.m. UTC | #4
> > Applied to for-next, thanks!
> 
> I applied the DTS patches, because they should go via arm-soc tree.
> Please drop them from I2C.

Sure thing! I replied to the wrong mail, I am sorry for the noise. I
didn't apply patch 7 but 6.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exynos5260.dtsi
index 52fa211525ce..524d244050e0 100644
--- a/arch/arm/boot/dts/exynos5260.dtsi
+++ b/arch/arm/boot/dts/exynos5260.dtsi
@@ -368,7 +368,7 @@  mmc_2: mmc@12160000 {
 			status = "disabled";
 		};
 
-		hsi2c_0: hsi2c@12da0000 {
+		hsi2c_0: i2c@12da0000 {
 			compatible = "samsung,exynos5260-hsi2c";
 			reg = <0x12DA0000 0x1000>;
 			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
@@ -381,7 +381,7 @@  hsi2c_0: hsi2c@12da0000 {
 			status = "disabled";
 		};
 
-		hsi2c_1: hsi2c@12db0000 {
+		hsi2c_1: i2c@12db0000 {
 			compatible = "samsung,exynos5260-hsi2c";
 			reg = <0x12DB0000 0x1000>;
 			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
@@ -394,7 +394,7 @@  hsi2c_1: hsi2c@12db0000 {
 			status = "disabled";
 		};
 
-		hsi2c_2: hsi2c@12dc0000 {
+		hsi2c_2: i2c@12dc0000 {
 			compatible = "samsung,exynos5260-hsi2c";
 			reg = <0x12DC0000 0x1000>;
 			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
@@ -407,7 +407,7 @@  hsi2c_2: hsi2c@12dc0000 {
 			status = "disabled";
 		};
 
-		hsi2c_3: hsi2c@12dd0000 {
+		hsi2c_3: i2c@12dd0000 {
 			compatible = "samsung,exynos5260-hsi2c";
 			reg = <0x12DD0000 0x1000>;
 			interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;