| Message ID | 20211206174237.2298580-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | c99a83a28d1676599956bec12a310066bf44c0ca |
| Headers | show |
| Series | dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells' | expand |
On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote: > '#interrupt-cells' is not documented which causes a warning when > 'unevaluatedProperties' is implemented. Unless the I2C controller is > also an interrupt controller, '#interrupt-cells' is not valid. This > doesn't appear to be the case from the driver, so just remove it from > the example. > > Cc: Brendan Higgins <brendanhiggins@google.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Joel Stanley <joel@jms.id.au> > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Rayn Chen <rayn_chen@aspeedtech.com> > Cc: linux-i2c@vger.kernel.org > Cc: openbmc@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-aspeed@lists.ozlabs.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 - > 1 file changed, 1 deletion(-) Interestingly I have a patch for this as well but it does the opposite and adds interrupt-controller and #interrupt-cells. Upon closer inspection I was tricked into this because the i2c-aspeed driver includes linux/irqchip/chained_irq.h and linux/irqdomain.h and therefore I assumed that it was indeed implementing an interrupt controller. But none of the symbols in those files are ever used, so your version seems to be correct. Reviewed-by: Thierry Reding <treding@nvidia.com>
On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote: > '#interrupt-cells' is not documented which causes a warning when > 'unevaluatedProperties' is implemented. Unless the I2C controller is > also an interrupt controller, '#interrupt-cells' is not valid. This > doesn't appear to be the case from the driver, so just remove it from > the example. > > Cc: Brendan Higgins <brendanhiggins@google.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Joel Stanley <joel@jms.id.au> > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Rayn Chen <rayn_chen@aspeedtech.com> > Cc: linux-i2c@vger.kernel.org > Cc: openbmc@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-aspeed@lists.ozlabs.org > Signed-off-by: Rob Herring <robh@kernel.org> Applied to for-next, thanks!
diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml index ea643e6c3ef5..f597f73ccd87 100644 --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml @@ -63,7 +63,6 @@ examples: i2c0: i2c-bus@40 { #address-cells = <1>; #size-cells = <0>; - #interrupt-cells = <1>; compatible = "aspeed,ast2500-i2c-bus"; reg = <0x40 0x40>; clocks = <&syscon ASPEED_CLK_APB>;
'#interrupt-cells' is not documented which causes a warning when 'unevaluatedProperties' is implemented. Unless the I2C controller is also an interrupt controller, '#interrupt-cells' is not valid. This doesn't appear to be the case from the driver, so just remove it from the example. Cc: Brendan Higgins <brendanhiggins@google.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Joel Stanley <joel@jms.id.au> Cc: Andrew Jeffery <andrew@aj.id.au> Cc: Rayn Chen <rayn_chen@aspeedtech.com> Cc: linux-i2c@vger.kernel.org Cc: openbmc@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-aspeed@lists.ozlabs.org Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 - 1 file changed, 1 deletion(-)