| Message ID | 20211204143725.31646-3-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On Sat, Dec 04, 2021 at 05:37:05PM +0300, Dmitry Osipenko wrote: > Convert NVIDIA Tegra20 I2S binding to schema. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../bindings/sound/nvidia,tegra20-i2s.txt | 30 -------- > .../bindings/sound/nvidia,tegra20-i2s.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt > deleted file mode 100644 > index dc30c6bfbe95..000000000000 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -NVIDIA Tegra 20 I2S controller > - > -Required properties: > -- compatible : "nvidia,tegra20-i2s" > -- reg : Should contain I2S registers location and length > -- interrupts : Should contain I2S interrupt > -- resets : Must contain an entry for each entry in reset-names. > - See ../reset/reset.txt for details. > -- reset-names : Must include the following entries: > - - i2s > -- dmas : Must contain an entry for each entry in clock-names. > - See ../dma/dma.txt for details. > -- dma-names : Must include the following entries: > - - rx > - - tx > -- clocks : Must contain one entry, for the module clock. > - See ../clocks/clock-bindings.txt for details. > - > -Example: > - > -i2s@70002800 { > - compatible = "nvidia,tegra20-i2s"; > - reg = <0x70002800 0x200>; > - interrupts = < 45 >; > - clocks = <&tegra_car 11>; > - resets = <&tegra_car 11>; > - reset-names = "i2s"; > - dmas = <&apbdma 21>, <&apbdma 21>; > - dma-names = "rx", "tx"; > -}; > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml > new file mode 100644 > index 000000000000..ad43b237d9af > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra20-i2s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra20 I2S Controller > + > +description: | > + The I2S Controller streams synchronous serial audio data between system > + memory and an external audio device. The controller supports the I2S Left > + Justified Mode, Right Justified Mode, and DSP mode formats. > + > +maintainers: > + - Thierry Reding <treding@nvidia.com> > + - Jon Hunter <jonathanh@nvidia.com> > + > +properties: > + compatible: > + const: nvidia,tegra20-i2s > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: i2s > + > + interrupts: > + maxItems: 1 I prefer ordering these by the same order that we typically have in device tree, so "compatible", "reg", "interrupts", "clocks", "clock-names", "resets", "reset-names", "dmas", "dma-names". I find that clearer because it lists the common properties at the top and the less common ones (such as "dmas") at the bottom. Anyway, it doesn't really matter, so: Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt deleted file mode 100644 index dc30c6bfbe95..000000000000 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt +++ /dev/null @@ -1,30 +0,0 @@ -NVIDIA Tegra 20 I2S controller - -Required properties: -- compatible : "nvidia,tegra20-i2s" -- reg : Should contain I2S registers location and length -- interrupts : Should contain I2S interrupt -- resets : Must contain an entry for each entry in reset-names. - See ../reset/reset.txt for details. -- reset-names : Must include the following entries: - - i2s -- dmas : Must contain an entry for each entry in clock-names. - See ../dma/dma.txt for details. -- dma-names : Must include the following entries: - - rx - - tx -- clocks : Must contain one entry, for the module clock. - See ../clocks/clock-bindings.txt for details. - -Example: - -i2s@70002800 { - compatible = "nvidia,tegra20-i2s"; - reg = <0x70002800 0x200>; - interrupts = < 45 >; - clocks = <&tegra_car 11>; - resets = <&tegra_car 11>; - reset-names = "i2s"; - dmas = <&apbdma 21>, <&apbdma 21>; - dma-names = "rx", "tx"; -}; diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml new file mode 100644 index 000000000000..ad43b237d9af --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nvidia,tegra20-i2s.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NVIDIA Tegra20 I2S Controller + +description: | + The I2S Controller streams synchronous serial audio data between system + memory and an external audio device. The controller supports the I2S Left + Justified Mode, Right Justified Mode, and DSP mode formats. + +maintainers: + - Thierry Reding <treding@nvidia.com> + - Jon Hunter <jonathanh@nvidia.com> + +properties: + compatible: + const: nvidia,tegra20-i2s + + reg: + maxItems: 1 + + resets: + maxItems: 1 + + reset-names: + const: i2s + + interrupts: + maxItems: 1 + + clocks: + minItems: 1 + + dmas: + minItems: 2 + + dma-names: + items: + - const: rx + - const: tx + +required: + - compatible + - reg + - resets + - reset-names + - interrupts + - clocks + - dmas + - dma-names + +additionalProperties: false + +examples: + - | + i2s@70002800 { + compatible = "nvidia,tegra20-i2s"; + reg = <0x70002800 0x200>; + interrupts = <45>; + clocks = <&tegra_car 11>; + resets = <&tegra_car 11>; + reset-names = "i2s"; + dmas = <&apbdma 21>, <&apbdma 21>; + dma-names = "rx", "tx"; + }; + +...