diff mbox series

HID: add USB_HID dependancy to hid-prodikeys

Message ID 20211203081231.2856936-1-gregkh@linuxfoundation.org
State Accepted
Commit 30cb3c2ad24b66fb7639a6d1f4390c74d6e68f94
Headers show
Series HID: add USB_HID dependancy to hid-prodikeys | expand

Commit Message

Greg KH Dec. 3, 2021, 8:12 a.m. UTC
The prodikeys HID driver only controls USB devices, yet did not have a
dependancy on USB_HID.  This causes build errors on some configurations
like nios2 when building due to new changes to the prodikeys driver.

Reported-by: kernel test robot <lkp@intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/hid/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Benjamin Tissoires Dec. 3, 2021, 8:43 a.m. UTC | #1
On Fri, Dec 3, 2021 at 9:12 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The prodikeys HID driver only controls USB devices, yet did not have a
> dependancy on USB_HID.  This causes build errors on some configurations
> like nios2 when building due to new changes to the prodikeys driver.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

Applied to for-5.16/upstream-fixes in hid.git

thanks

Cheers,
Benjamin

>  drivers/hid/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index e9bc8efed5a1..a7c78ac96270 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -245,7 +245,7 @@ config HID_MACALLY
>
>  config HID_PRODIKEYS
>         tristate "Prodikeys PC-MIDI Keyboard support"
> -       depends on HID && SND
> +       depends on USB_HID && SND
>         select SND_RAWMIDI
>         help
>         Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index e9bc8efed5a1..a7c78ac96270 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -245,7 +245,7 @@  config HID_MACALLY
 
 config HID_PRODIKEYS
 	tristate "Prodikeys PC-MIDI Keyboard support"
-	depends on HID && SND
+	depends on USB_HID && SND
 	select SND_RAWMIDI
 	help
 	Support for Prodikeys PC-MIDI Keyboard device support.