| Message ID | 20211202093230.3951996-1-andrej.picej@norik.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/4] mfd: da9062: make register CONFIG_I writable | expand |
On 02 December 2021 09:32, Andrej Picej wrote: > From: Stefan Christ <s.christ@phytec.de> > > Make the config register CONFIG_I writable to change the watchdog mode. > > Signed-off-by: Stefan Christ <s.christ@phytec.de> > Signed-off-by: Andrej Picej <andrej.picej@norik.com> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
On Thu, Dec 02, 2021 at 10:32:27AM +0100, Andrej Picej wrote: > From: Stefan Christ <s.christ@phytec.de> > > Make the config register CONFIG_I writable to change the watchdog mode. > > Signed-off-by: Stefan Christ <s.christ@phytec.de> > Signed-off-by: Andrej Picej <andrej.picej@norik.com> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > Chnages in v4: > - no changes > > Changes in v3: > - no chagnes > > Changes in v2: > - no changes > --- > drivers/mfd/da9062-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c > index 01f8e10dfa55..7041ba53efb4 100644 > --- a/drivers/mfd/da9062-core.c > +++ b/drivers/mfd/da9062-core.c > @@ -556,6 +556,7 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = { > regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), > regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), > regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), > + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), > regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), > }; > > -- > 2.25.1 >
On 2. 12. 21 16:18, Christoph Niedermaier wrote: > From: Andrej Picej > Sent: Thursday, December 2, 2021 10:32 AM >> From: Stefan Christ <s.christ@phytec.de> >> >> Make the config register CONFIG_I writable to change the watchdog mode. >> >> Signed-off-by: Stefan Christ <s.christ@phytec.de> >> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >> --- >> Chnages in v4: >> - no changes >> >> Changes in v3: >> - no chagnes >> >> Changes in v2: >> - no changes >> --- >> drivers/mfd/da9062-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c >> index 01f8e10dfa55..7041ba53efb4 100644 >> --- a/drivers/mfd/da9062-core.c >> +++ b/drivers/mfd/da9062-core.c >> @@ -556,6 +556,7 @@ static const struct regmap_range >> da9062_aa_writeable_ranges[] = { >> regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), >> regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), >> regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), >> + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), >> regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), >> }; > Could you also include the CONFIG_I for the DA9061? > So I can test it on my system. > Yes, I don't see the problem here. @Maintainers, should I send a new version with this (then I would also fix the minor spelling mistake in commit message of 2/4), or do you prefer a separate patch? Thanks, Andrej.
On 12/3/21 12:59 AM, Andrej Picej wrote: > > > On 2. 12. 21 16:18, Christoph Niedermaier wrote: >> From: Andrej Picej >> Sent: Thursday, December 2, 2021 10:32 AM >>> From: Stefan Christ <s.christ@phytec.de> >>> >>> Make the config register CONFIG_I writable to change the watchdog mode. >>> >>> Signed-off-by: Stefan Christ <s.christ@phytec.de> >>> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >>> --- >>> Chnages in v4: >>> - no changes >>> >>> Changes in v3: >>> - no chagnes >>> >>> Changes in v2: >>> - no changes >>> --- >>> drivers/mfd/da9062-core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c >>> index 01f8e10dfa55..7041ba53efb4 100644 >>> --- a/drivers/mfd/da9062-core.c >>> +++ b/drivers/mfd/da9062-core.c >>> @@ -556,6 +556,7 @@ static const struct regmap_range >>> da9062_aa_writeable_ranges[] = { >>> regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), >>> regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), >>> regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), >>> + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), >>> regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), >>> }; > >> Could you also include the CONFIG_I for the DA9061? >> So I can test it on my system. >> > > Yes, I don't see the problem here. > @Maintainers, should I send a new version with this (then I would also fix the minor spelling mistake in commit message of 2/4), or do you prefer a separate patch? > Either way is fine, with a slight preference on sending a new version. Guenter
diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c index 01f8e10dfa55..7041ba53efb4 100644 --- a/drivers/mfd/da9062-core.c +++ b/drivers/mfd/da9062-core.c @@ -556,6 +556,7 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = { regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), };