| Message ID | 1438863435-5742-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 9b7aca9100fa27cddc4385931cd82a76e2bad0f7 |
| Headers | show |
Mike, Stuart, ok? Maxim. On 08/06/15 15:17, Maxim Uvarov wrote: > Usually odp_generator exists when veth is destroyed, but not > always. Because cpu load impacts on other performance tests > we have to be sure that odp_generator is not running in background. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > v2: kill by pid instead of killall > > test/performance/odp_l2fwd_run | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/performance/odp_l2fwd_run b/test/performance/odp_l2fwd_run > index e89bec8..c20a3e1 100755 > --- a/test/performance/odp_l2fwd_run > +++ b/test/performance/odp_l2fwd_run > @@ -59,10 +59,13 @@ run_l2fwd() > (odp_generator${EXEEXT} -I $IF0 \ > --srcip 192.168.0.1 --dstip 192.168.0.2 -m u 2>&1 > /dev/null) \ > 2>&1 > /dev/null & > + GEN_PID=$! > > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > > + kill ${GEN_PID} > + > cleanup_pktio_env > if [ $? -ne 0 ]; then > echo "cleanup_pktio_env error $?"
Yes, happy for my reviewed-by from before, Stuarts suggestion just makes it better On 10 August 2015 at 05:13, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Mike, Stuart, ok? > > Maxim. > > > On 08/06/15 15:17, Maxim Uvarov wrote: > >> Usually odp_generator exists when veth is destroyed, but not >> always. Because cpu load impacts on other performance tests >> we have to be sure that odp_generator is not running in background. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> v2: kill by pid instead of killall >> >> test/performance/odp_l2fwd_run | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/test/performance/odp_l2fwd_run >> b/test/performance/odp_l2fwd_run >> index e89bec8..c20a3e1 100755 >> --- a/test/performance/odp_l2fwd_run >> +++ b/test/performance/odp_l2fwd_run >> @@ -59,10 +59,13 @@ run_l2fwd() >> (odp_generator${EXEEXT} -I $IF0 \ >> --srcip 192.168.0.1 --dstip 192.168.0.2 -m u 2>&1 >> > /dev/null) \ >> 2>&1 > /dev/null & >> + GEN_PID=$! >> echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" >> odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 >> + kill ${GEN_PID} >> + >> cleanup_pktio_env >> if [ $? -ne 0 ]; then >> echo "cleanup_pktio_env error $?" >> > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, changed topic from validation: to test: due to it's not validation test. Maxim. On 08/10/15 14:50, Mike Holmes wrote: > Yes, happy for my reviewed-by from before, Stuarts suggestion just > makes it better > > On 10 August 2015 at 05:13, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > Mike, Stuart, ok? > > Maxim. > > > On 08/06/15 15:17, Maxim Uvarov wrote: > > Usually odp_generator exists when veth is destroyed, but not > always. Because cpu load impacts on other performance tests > we have to be sure that odp_generator is not running in > background. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > --- > v2: kill by pid instead of killall > > test/performance/odp_l2fwd_run | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/performance/odp_l2fwd_run > b/test/performance/odp_l2fwd_run > index e89bec8..c20a3e1 100755 > --- a/test/performance/odp_l2fwd_run > +++ b/test/performance/odp_l2fwd_run > @@ -59,10 +59,13 @@ run_l2fwd() > (odp_generator${EXEEXT} -I $IF0 \ > --srcip 192.168.0.1 --dstip > 192.168.0.2 -m u 2>&1 > /dev/null) \ > 2>&1 > /dev/null & > + GEN_PID=$! > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > + kill ${GEN_PID} > + > cleanup_pktio_env > if [ $? -ne 0 ]; then > echo "cleanup_pktio_env error $?" > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs >
diff --git a/test/performance/odp_l2fwd_run b/test/performance/odp_l2fwd_run index e89bec8..c20a3e1 100755 --- a/test/performance/odp_l2fwd_run +++ b/test/performance/odp_l2fwd_run @@ -59,10 +59,13 @@ run_l2fwd() (odp_generator${EXEEXT} -I $IF0 \ --srcip 192.168.0.1 --dstip 192.168.0.2 -m u 2>&1 > /dev/null) \ 2>&1 > /dev/null & + GEN_PID=$! echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 + kill ${GEN_PID} + cleanup_pktio_env if [ $? -ne 0 ]; then echo "cleanup_pktio_env error $?"
Usually odp_generator exists when veth is destroyed, but not always. Because cpu load impacts on other performance tests we have to be sure that odp_generator is not running in background. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- v2: kill by pid instead of killall test/performance/odp_l2fwd_run | 3 +++ 1 file changed, 3 insertions(+)