| Message ID | 20211201150440.1088-5-sj@kernel.org |
|---|---|
| State | Accepted |
| Commit | 09e12289cc044afa484e70c0b379d579d52caf9a |
| Headers | show |
| Series | [01/11] mm/damon/core: Use better timer mechanisms selection threshold | expand |
On Wed, Dec 1, 2021 at 11:05 PM SeongJae Park <sj@kernel.org> wrote: > > The DAMON virtual address space monitoring primitive prints a warning > message for wrong DAMOS action. However, it is not essential as the > code returns appropriate failure in the case. This commit removes the > message to make the log clean. > > Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes") I don't think there should be a Fixes tag since it's not a serious bug. Without this: Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On Fri, 3 Dec 2021 11:01:36 +0800 Muchun Song <songmuchun@bytedance.com> wrote: > On Wed, Dec 1, 2021 at 11:05 PM SeongJae Park <sj@kernel.org> wrote: > > > > The DAMON virtual address space monitoring primitive prints a warning > > message for wrong DAMOS action. However, it is not essential as the > > code returns appropriate failure in the case. This commit removes the > > message to make the log clean. > > > > Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes") > > I don't think there should be a Fixes tag since it's not a serious bug. "Fixes:" doesn't mean "backport to stable". At least, not for MM patches. Other subsystems do get their Fixes:-tagged patches automatically backported.
On Sat, Dec 4, 2021 at 4:44 AM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Fri, 3 Dec 2021 11:01:36 +0800 Muchun Song <songmuchun@bytedance.com> wrote: > > > On Wed, Dec 1, 2021 at 11:05 PM SeongJae Park <sj@kernel.org> wrote: > > > > > > The DAMON virtual address space monitoring primitive prints a warning > > > message for wrong DAMOS action. However, it is not essential as the > > > code returns appropriate failure in the case. This commit removes the > > > message to make the log clean. > > > > > > Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes") > > > > I don't think there should be a Fixes tag since it's not a serious bug. > > "Fixes:" doesn't mean "backport to stable". At least, not for MM > patches. Other subsystems do get their Fixes:-tagged patches > automatically backported. > Got it. Thanks.
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 79481f0c2838..a65b1a4d236c 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -617,7 +617,6 @@ static int damon_va_apply_scheme(struct damon_ctx *ctx, struct damon_target *t, case DAMOS_STAT: return 0; default: - pr_warn("Wrong action %d\n", scheme->action); return -EINVAL; }
The DAMON virtual address space monitoring primitive prints a warning message for wrong DAMOS action. However, it is not essential as the code returns appropriate failure in the case. This commit removes the message to make the log clean. Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes") Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/vaddr.c | 1 - 1 file changed, 1 deletion(-)