| Message ID | 45d35e38970b9c7196faa3a6892d2b5e4e6f40aa.1438851213.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 06-08-15, 14:25, Viresh Kumar wrote: > This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer: > Migrate to new 'set-state' interface") commit, but it wasn't. > > Remove it now. > > Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface") > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Ralf: > > Not sure how it was left out in my series, but I thought it should have > been caught by the compilers as the function hpet_set_mode doesn't exist > today. > > Either merge it with the offending commit or keep it separate. > > arch/mips/loongson64/loongson-3/hpet.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c > index 950096e8d7cd..bf9f1a77f0e5 100644 > --- a/arch/mips/loongson64/loongson-3/hpet.c > +++ b/arch/mips/loongson64/loongson-3/hpet.c > @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void) > cd->name = "hpet"; > cd->rating = 320; > cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; > - cd->set_mode = hpet_set_mode; > cd->set_state_shutdown = hpet_set_state_shutdown; > cd->set_state_periodic = hpet_set_state_periodic; > cd->set_state_oneshot = hpet_set_state_oneshot; Ping
On 12-08-15, 15:48, Viresh Kumar wrote: > On 06-08-15, 14:25, Viresh Kumar wrote: > > This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer: > > Migrate to new 'set-state' interface") commit, but it wasn't. > > > > Remove it now. > > > > Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface") > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > Ralf: > > > > Not sure how it was left out in my series, but I thought it should have > > been caught by the compilers as the function hpet_set_mode doesn't exist > > today. > > > > Either merge it with the offending commit or keep it separate. > > > > arch/mips/loongson64/loongson-3/hpet.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c > > index 950096e8d7cd..bf9f1a77f0e5 100644 > > --- a/arch/mips/loongson64/loongson-3/hpet.c > > +++ b/arch/mips/loongson64/loongson-3/hpet.c > > @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void) > > cd->name = "hpet"; > > cd->rating = 320; > > cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; > > - cd->set_mode = hpet_set_mode; > > cd->set_state_shutdown = hpet_set_state_shutdown; > > cd->set_state_periodic = hpet_set_state_periodic; > > cd->set_state_oneshot = hpet_set_state_oneshot; > > Ping Another Ping !!
diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c index 950096e8d7cd..bf9f1a77f0e5 100644 --- a/arch/mips/loongson64/loongson-3/hpet.c +++ b/arch/mips/loongson64/loongson-3/hpet.c @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void) cd->name = "hpet"; cd->rating = 320; cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; - cd->set_mode = hpet_set_mode; cd->set_state_shutdown = hpet_set_state_shutdown; cd->set_state_periodic = hpet_set_state_periodic; cd->set_state_oneshot = hpet_set_state_oneshot;
This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface") commit, but it wasn't. Remove it now. Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface") Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Ralf: Not sure how it was left out in my series, but I thought it should have been caught by the compilers as the function hpet_set_mode doesn't exist today. Either merge it with the offending commit or keep it separate. arch/mips/loongson64/loongson-3/hpet.c | 1 - 1 file changed, 1 deletion(-)