| Message ID | 20211022141008.2846454-2-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | wcn36xx: Revert firmware link monitoring | expand |
On Fri, 22 Oct 2021 at 16:08, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Benjamin Li <benl@squareup.com> Should it get a 'Fixes' tag? Regards, Loic > --- > drivers/net/wireless/ath/wcn36xx/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c > index dd8810fd76a3d..fd8b2753da7dd 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) > ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL); > ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS); > ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS); > - ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); > > wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | > BIT(NL80211_IFTYPE_AP) | > -- > 2.33.0 > _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx
Loic Poulain <loic.poulain@linaro.org> writes: > On Fri, 22 Oct 2021 at 16:08, Bryan O'Donoghue > <bryan.odonoghue@linaro.org> wrote: >> >> This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> Signed-off-by: Benjamin Li <benl@squareup.com> > > Should it get a 'Fixes' tag? But this patch is not really fixing anything, right? I wonder if there's patch 2 missing? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> The commit log should answer to question "why?". Please move the explanation from the cover email to the commit log. > Signed-off-by: Benjamin Li <benl@squareup.com> Why Benjamin's s-o-b? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index dd8810fd76a3d..fd8b2753da7dd 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL); ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS); ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS); - ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_AP) |