diff mbox series

[v1,1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory

Message ID 20211004134742.2044280-2-alex.bennee@linaro.org
State New
Headers show
Series enabling RasperryPi 4 emulation - WIP state | expand

Commit Message

Alex Bennée Oct. 4, 2021, 1:47 p.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>


We are returning unintialized memory, this is probably unsafe.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 hw/misc/bcm2835_property.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.30.2
diff mbox series

Patch

diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 73941bdae9..791c7554ec 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -61,6 +61,7 @@  static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
             qemu_log_mask(LOG_UNIMP,
                           "bcm2835_property: 0x%08x get board model NYI\n",
                           tag);
+            /* FIXME returning uninitialized memory */
             resplen = 4;
             break;
         case 0x00010002: /* Get board revision */
@@ -75,6 +76,7 @@  static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
             qemu_log_mask(LOG_UNIMP,
                           "bcm2835_property: 0x%08x get board serial NYI\n",
                           tag);
+            /* FIXME returning uninitialized memory */
             resplen = 8;
             break;
         case 0x00010005: /* Get ARM memory */