| Message ID | 20210924214844.1890478-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] arm: dts: vexpress: Set chosen 'stdout-path' | expand |
Hi Rob, On Fri, Sep 24, 2021 at 04:48:44PM -0500, Rob Herring wrote: > Using chosen 'stdout-path' is the preferred way to set the console, but > several Arm, Ltd. platforms don't set it. Set it to the 1st serial port. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > RFC because I don't have any idea what the baud rate is for real boards. > If anyone knows, please comment and I'll add it. I believe all of them default to 115200,8n1 but I'm only sure about the first two boards. Best regards, Liviu > > arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts | 4 +++- > arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts | 4 +++- > arch/arm/boot/dts/vexpress-v2p-ca5s.dts | 4 +++- > arch/arm/boot/dts/vexpress-v2p-ca9.dts | 4 +++- > arch/arm64/boot/dts/arm/foundation-v8.dtsi | 4 +++- > arch/arm64/boot/dts/arm/fvp-base-revc.dts | 4 +++- > arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 4 +++- > 7 files changed, 21 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts b/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts > index 679537e17ff5..c296a3677447 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts > @@ -20,7 +20,9 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > index 511e87cc2bc5..7b7c1ec2f542 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > @@ -20,7 +20,9 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca5s.dts b/arch/arm/boot/dts/vexpress-v2p-ca5s.dts > index 3b88209bacea..9b70ae1d3e35 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca5s.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca5s.dts > @@ -20,7 +20,9 @@ / { > #address-cells = <1>; > #size-cells = <1>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca9.dts b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > index 5916e4877eac..4eef3db16b3d 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca9.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > @@ -20,7 +20,9 @@ / { > #address-cells = <1>; > #size-cells = <1>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dtsi b/arch/arm64/boot/dts/arm/foundation-v8.dtsi > index fbf13f7c2baf..6eb14717cb4d 100644 > --- a/arch/arm64/boot/dts/arm/foundation-v8.dtsi > +++ b/arch/arm64/boot/dts/arm/foundation-v8.dtsi > @@ -18,7 +18,9 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts > index 5f519affe728..a6165a472a7b 100644 > --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts > +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts > @@ -24,7 +24,9 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > index 258991ad7cc0..f8dee952cefc 100644 > --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > @@ -23,7 +23,9 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > - chosen { }; > + chosen { > + stdout-path = "serial0"; > + }; > > aliases { > serial0 = &v2m_serial0; > -- > 2.30.2 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
On Wed, Sep 29, 2021 at 04:31:59PM +0100, Liviu Dudau wrote: > Hi Rob, > > On Fri, Sep 24, 2021 at 04:48:44PM -0500, Rob Herring wrote: > > Using chosen 'stdout-path' is the preferred way to set the console, but > > several Arm, Ltd. platforms don't set it. Set it to the 1st serial port. > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > RFC because I don't have any idea what the baud rate is for real boards. > > If anyone knows, please comment and I'll add it. > > I believe all of them default to 115200,8n1 but I'm only sure about the first two > boards. > Sorry to contradict, but I ran TC2 this Monday with 38400 baud. So the first four must be 38400, as the uart is in the MB IOFPGA and we just change the coretile DB to get the first 4 platforms. Juno and N1SDP have SoC uart and they are configured by default to 115200 IIUC. -- Regards, Sudeep
On Fri, Oct 01, 2021 at 10:25:05AM +0100, Sudeep Holla wrote: > On Wed, Sep 29, 2021 at 04:31:59PM +0100, Liviu Dudau wrote: > > Hi Rob, > > > > On Fri, Sep 24, 2021 at 04:48:44PM -0500, Rob Herring wrote: > > > Using chosen 'stdout-path' is the preferred way to set the console, but > > > several Arm, Ltd. platforms don't set it. Set it to the 1st serial port. > > > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > Cc: linux-arm-kernel@lists.infradead.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > RFC because I don't have any idea what the baud rate is for real boards. > > > If anyone knows, please comment and I'll add it. > > > > I believe all of them default to 115200,8n1 but I'm only sure about the first two > > boards. > > > > Sorry to contradict, but I ran TC2 this Monday with 38400 baud. So the first > four must be 38400, as the uart is in the MB IOFPGA and we just change the > coretile DB to get the first 4 platforms. Juno and N1SDP have SoC uart and > they are configured by default to 115200 IIUC. Huh, you're right! I guess I was trying to cover some painful memories :) Sorry for the noise Rob, please listen to Sudeep. Best regards, Liviu > > -- > Regards, > Sudeep -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts b/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts index 679537e17ff5..c296a3677447 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts @@ -20,7 +20,9 @@ / { #address-cells = <2>; #size-cells = <2>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts index 511e87cc2bc5..7b7c1ec2f542 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts @@ -20,7 +20,9 @@ / { #address-cells = <2>; #size-cells = <2>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm/boot/dts/vexpress-v2p-ca5s.dts b/arch/arm/boot/dts/vexpress-v2p-ca5s.dts index 3b88209bacea..9b70ae1d3e35 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca5s.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca5s.dts @@ -20,7 +20,9 @@ / { #address-cells = <1>; #size-cells = <1>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm/boot/dts/vexpress-v2p-ca9.dts b/arch/arm/boot/dts/vexpress-v2p-ca9.dts index 5916e4877eac..4eef3db16b3d 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca9.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca9.dts @@ -20,7 +20,9 @@ / { #address-cells = <1>; #size-cells = <1>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dtsi b/arch/arm64/boot/dts/arm/foundation-v8.dtsi index fbf13f7c2baf..6eb14717cb4d 100644 --- a/arch/arm64/boot/dts/arm/foundation-v8.dtsi +++ b/arch/arm64/boot/dts/arm/foundation-v8.dtsi @@ -18,7 +18,9 @@ / { #address-cells = <2>; #size-cells = <2>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts index 5f519affe728..a6165a472a7b 100644 --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts @@ -24,7 +24,9 @@ / { #address-cells = <2>; #size-cells = <2>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0; diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts index 258991ad7cc0..f8dee952cefc 100644 --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts @@ -23,7 +23,9 @@ / { #address-cells = <2>; #size-cells = <2>; - chosen { }; + chosen { + stdout-path = "serial0"; + }; aliases { serial0 = &v2m_serial0;
Using chosen 'stdout-path' is the preferred way to set the console, but several Arm, Ltd. platforms don't set it. Set it to the 1st serial port. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- RFC because I don't have any idea what the baud rate is for real boards. If anyone knows, please comment and I'll add it. arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts | 4 +++- arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts | 4 +++- arch/arm/boot/dts/vexpress-v2p-ca5s.dts | 4 +++- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 4 +++- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 4 +++- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 4 +++- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 4 +++- 7 files changed, 21 insertions(+), 7 deletions(-) -- 2.30.2