diff mbox series

scsi: lpfc: use correct scnprintf() limit

Message ID 20210916132331.GE25094@kili
State New
Headers show
Series scsi: lpfc: use correct scnprintf() limit | expand

Commit Message

Dan Carpenter Sept. 16, 2021, 1:23 p.m. UTC 
The limit should be "PAGE_SIZE - len" instead of "PAGE_SIZE".
We're not going to hit the limit so this fix will not affect runtime.

Fixes: 5b9e70b22cc5 ("scsi: lpfc: raise sg count for nvme to use available sg resources")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/lpfc/lpfc_attr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 22, 2021, 4:44 a.m. UTC | #1 
On Thu, 16 Sep 2021 16:23:31 +0300, Dan Carpenter wrote:

> The limit should be "PAGE_SIZE - len" instead of "PAGE_SIZE".

> We're not going to hit the limit so this fix will not affect runtime.

> 

> 


Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: lpfc: use correct scnprintf() limit
      https://git.kernel.org/mkp/scsi/c/6dacc371b77f

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index b35bf70a8c0d..1e5a30eb04de 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -6204,7 +6204,8 @@  lpfc_sg_seg_cnt_show(struct device *dev, struct device_attribute *attr,
 	len = scnprintf(buf, PAGE_SIZE, "SGL sz: %d  total SGEs: %d\n",
 		       phba->cfg_sg_dma_buf_size, phba->cfg_total_seg_cnt);
 
-	len += scnprintf(buf + len, PAGE_SIZE, "Cfg: %d  SCSI: %d  NVME: %d\n",
+	len += scnprintf(buf + len, PAGE_SIZE - len,
+			"Cfg: %d  SCSI: %d  NVME: %d\n",
 			phba->cfg_sg_seg_cnt, phba->cfg_scsi_seg_cnt,
 			phba->cfg_nvme_seg_cnt);
 	return len;