| Message ID | 20210916170517.138035-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted |
| Commit | 511899ec34b605af5f8577f0f53866a8a60939f6 |
| Headers | show |
| Series | i2c: pxa: drop unneeded MODULE_ALIAS | expand |
On Thu, Sep 16, 2021 at 07:05:17PM +0200, Krzysztof Kozlowski wrote: > The MODULE_DEVICE_TABLE already creates proper alias for platform > driver. Having another MODULE_ALIAS causes the alias to be duplicated. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Applied to for-next, thanks! Good catch. Do you want to fix all of these duplicates in the tree? I found two handful of the same pattern and could assist you in removing themt. But I also don't want to steal your credits. Let me know if I can help.
On 02/10/2021 09:31, Wolfram Sang wrote: > On Thu, Sep 16, 2021 at 07:05:17PM +0200, Krzysztof Kozlowski wrote: >> The MODULE_DEVICE_TABLE already creates proper alias for platform >> driver. Having another MODULE_ALIAS causes the alias to be duplicated. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > Applied to for-next, thanks! > > Good catch. Do you want to fix all of these duplicates in the tree? I > found two handful of the same pattern and could assist you in removing > themt. But I also don't want to steal your credits. Let me know if I can > help. > I think I fixed all of platform aliases. I also removed duplicates for few USB and ACPI (some others seems to be not an actual duplicate or intentional). All patches: https://lore.kernel.org/lkml/?q=f%3Akozlowski+MODULE_ALIAS If you see something not fixed, go ahead. Best regards, Krzysztof
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index a636ea0eb50a..690188a9ffff 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1547,7 +1547,6 @@ static void __exit i2c_adap_pxa_exit(void) } MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:pxa2xx-i2c"); subsys_initcall(i2c_adap_pxa_init); module_exit(i2c_adap_pxa_exit);
The MODULE_DEVICE_TABLE already creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/i2c/busses/i2c-pxa.c | 1 - 1 file changed, 1 deletion(-)