diff mbox series

spi: tegra20-slink: fix "defined but not used" if !CONFIG_PM

Message ID 20210912212519.11797-1-kilobyte@angband.pl
State New
Headers show
Series spi: tegra20-slink: fix "defined but not used" if !CONFIG_PM | expand

Commit Message

Adam Borowski Sept. 12, 2021, 9:25 p.m. UTC 
Because of warnings, esp. with new default -Werror.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
 drivers/spi/spi-tegra20-slink.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mark Brown Sept. 13, 2021, 11:12 a.m. UTC | #1 
On Sun, Sep 12, 2021 at 11:25:19PM +0200, Adam Borowski wrote:

> +#ifdef CONFIG_PM

>  static int tegra_slink_runtime_suspend(struct device *dev);

>  static int tegra_slink_runtime_resume(struct device *dev);

> +#endif


ifdefs are not an idiomatic fix, use __maybe_unused if you have to.
diff mbox series

Patch

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index ebd27f883033..c8b54c7c53d0 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -204,8 +204,10 @@  struct tegra_slink_data {
 	struct dma_async_tx_descriptor		*tx_dma_desc;
 };
 
+#ifdef CONFIG_PM
 static int tegra_slink_runtime_suspend(struct device *dev);
 static int tegra_slink_runtime_resume(struct device *dev);
+#endif
 
 static inline u32 tegra_slink_readl(struct tegra_slink_data *tspi,
 		unsigned long reg)
@@ -1185,6 +1187,7 @@  static int tegra_slink_resume(struct device *dev)
 }
 #endif
 
+#ifdef CONFIG_PM
 static int tegra_slink_runtime_suspend(struct device *dev)
 {
 	struct spi_master *master = dev_get_drvdata(dev);
@@ -1210,6 +1213,7 @@  static int tegra_slink_runtime_resume(struct device *dev)
 	}
 	return 0;
 }
+#endif
 
 static const struct dev_pm_ops slink_pm_ops = {
 	SET_RUNTIME_PM_OPS(tegra_slink_runtime_suspend,