diff mbox series

[7/8] clk: qcom: gpucc-msm8998: Remove unnecessary fallbacks to global clocks

Message ID 20210911121340.261920-8-marijn.suijten@somainline.org
State Accepted
Commit 7837187cb9ce52d0dcaaaa69a630b2c30b07dd08
Headers show
Series [1/8] clk: qcom: gcc-msm8998: Move parent names and mapping below GPLLs | expand

Commit Message

Marijn Suijten Sept. 11, 2021, 12:13 p.m. UTC 
A previous patch removes the "xo" clock from the global namespace making
it impossible to acquire by that ".name".  The device-tree for msm8998
already provides the "xo" and "gpll0" clock since the addition of the
gpucc node making it unnecessary to have this fallback at all.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
 drivers/clk/qcom/gpucc-msm8998.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Stephen Boyd Sept. 14, 2021, 9:42 p.m. UTC | #1 
Quoting Marijn Suijten (2021-09-11 05:13:39)
> A previous patch removes the "xo" clock from the global namespace making

> it impossible to acquire by that ".name".  The device-tree for msm8998

> already provides the "xo" and "gpll0" clock since the addition of the

> gpucc node making it unnecessary to have this fallback at all.

> 

> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>

> ---


Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gpucc-msm8998.c b/drivers/clk/qcom/gpucc-msm8998.c
index 3ac6fbfbd414..a925ac90018d 100644
--- a/drivers/clk/qcom/gpucc-msm8998.c
+++ b/drivers/clk/qcom/gpucc-msm8998.c
@@ -40,8 +40,7 @@  static struct clk_branch gpucc_cxo_clk = {
 		.hw.init = &(struct clk_init_data){
 			.name = "gpucc_cxo_clk",
 			.parent_data = &(const struct clk_parent_data){
-				.fw_name = "xo",
-				.name = "xo"
+				.fw_name = "xo"
 			},
 			.num_parents = 1,
 			.ops = &clk_branch2_ops,
@@ -99,7 +98,7 @@  static const struct parent_map gpu_xo_gpll0_map[] = {
 
 static const struct clk_parent_data gpu_xo_gpll0[] = {
 	{ .hw = &gpucc_cxo_clk.clkr.hw },
-	{ .fw_name = "gpll0", .name = "gpll0" },
+	{ .fw_name = "gpll0" },
 };
 
 static const struct parent_map gpu_xo_gpupll0_map[] = {