diff mbox series

[4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address

Message ID 20210909213118.1087083-5-robh@kernel.org
State Superseded
Headers show
Series Arm boards syscon 'unit_address_format' clean-ups | expand

Commit Message

Rob Herring (Arm) Sept. 9, 2021, 9:31 p.m. UTC
'reg' is the standard property for defining register banks/addresses. Add
it to use for the VCO register address and deprecate 'vco-offset'. This
will also allow for using standard node names with unit-addresses.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.30.2

Comments

Rob Herring (Arm) Sept. 10, 2021, 1:11 p.m. UTC | #1
On Thu, Sep 9, 2021 at 4:31 PM Rob Herring <robh@kernel.org> wrote:
>

> 'reg' is the standard property for defining register banks/addresses. Add

> it to use for the VCO register address and deprecate 'vco-offset'. This

> will also allow for using standard node names with unit-addresses.

>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Stephen Boyd <sboyd@kernel.org>

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: linux-clk@vger.kernel.org

> Cc: Michael Turquette <mturquette@baylibre.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++

>  1 file changed, 5 insertions(+)

>

> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml

> index 118c5543e037..c346287ca15d 100644

> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml

> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml

> @@ -69,6 +69,10 @@ properties:

>        - arm,impd1-vco1

>        - arm,impd1-vco2

>

> +  reg:

> +    maxItems: 1

> +    description: The VCO register

> +

>    clocks:

>      description: Parent clock for the ICST VCO

>      maxItems: 1

> @@ -83,6 +87,7 @@ properties:

>    vco-offset:

>      $ref: '/schemas/types.yaml#/definitions/uint32'

>      description: Offset to the VCO register for the oscillator

> +    deprecated


Sigh, that should be 'deprecated: true'.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
index 118c5543e037..c346287ca15d 100644
--- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
+++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
@@ -69,6 +69,10 @@  properties:
       - arm,impd1-vco1
       - arm,impd1-vco2
 
+  reg:
+    maxItems: 1
+    description: The VCO register
+
   clocks:
     description: Parent clock for the ICST VCO
     maxItems: 1
@@ -83,6 +87,7 @@  properties:
   vco-offset:
     $ref: '/schemas/types.yaml#/definitions/uint32'
     description: Offset to the VCO register for the oscillator
+    deprecated
 
 required:
   - "#clock-cells"