diff mbox series

media: i2c: ths8200 needs V4L2_ASYNC

Message ID 20210904232808.25638-1-rdunlap@infradead.org
State Accepted
Commit e4625044d656f3c33ece0cc9da22577bc10ca5d3
Headers show
Series media: i2c: ths8200 needs V4L2_ASYNC | expand

Commit Message

Randy Dunlap Sept. 4, 2021, 11:28 p.m. UTC
Fix the build errors reported by the kernel test robot by
selecting V4L2_ASYNC:

mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'

Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 drivers/media/i2c/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Lad, Prabhakar Sept. 5, 2021, 9:41 p.m. UTC | #1
Hi Randy,

Thank you for the patch.

On Sun, Sep 5, 2021 at 12:28 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>

> Fix the build errors reported by the kernel test robot by

> selecting V4L2_ASYNC:

>

> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':

> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'

> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':

> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'

>

> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Reported-by: kernel test robot <lkp@intel.com>

> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>

> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>

> Cc: Ezequiel Garcia <ezequiel@collabora.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: linux-media@vger.kernel.org

> ---

>  drivers/media/i2c/Kconfig |    1 +

>  1 file changed, 1 insertion(+)

>

Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>


Cheers,
Prabhakar

> --- linux-next-20210903.orig/drivers/media/i2c/Kconfig

> +++ linux-next-20210903/drivers/media/i2c/Kconfig

> @@ -597,6 +597,7 @@ config VIDEO_AK881X

>  config VIDEO_THS8200

>         tristate "Texas Instruments THS8200 video encoder"

>         depends on VIDEO_V4L2 && I2C

> +       select V4L2_ASYNC

>         help

>           Support for the Texas Instruments THS8200 video encoder.

>
Sakari Ailus Sept. 6, 2021, 7:56 a.m. UTC | #2
On Sat, Sep 04, 2021 at 04:28:08PM -0700, Randy Dunlap wrote:
> Fix the build errors reported by the kernel test robot by

> selecting V4L2_ASYNC:

> 

> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':

> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'

> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':

> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'

> 

> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Reported-by: kernel test robot <lkp@intel.com>

> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>

> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>

> Cc: Ezequiel Garcia <ezequiel@collabora.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: linux-media@vger.kernel.org


Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>


-- 
Sakari Ailus
diff mbox series

Patch

--- linux-next-20210903.orig/drivers/media/i2c/Kconfig
+++ linux-next-20210903/drivers/media/i2c/Kconfig
@@ -597,6 +597,7 @@  config VIDEO_AK881X
 config VIDEO_THS8200
 	tristate "Texas Instruments THS8200 video encoder"
 	depends on VIDEO_V4L2 && I2C
+	select V4L2_ASYNC
 	help
 	  Support for the Texas Instruments THS8200 video encoder.