[RESEND,v1,1/9] spmi: pmic-arb: add a print in cleanup_irq

Message ID	1630484290-28190-2-git-send-email-quic_fenglinw@quicinc.com
State	Superseded
Headers	show Return-Path: <linux-arm-msm-owner@kernel.org> From: Fenglin Wu <quic_fenglinw@quicinc.com> To: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <sboyd@kernel.org> CC: <collinsd@codeaurora.org>, <subbaram@codeaurora.org>, <quic_fenglinw@quicinc.com>, Abhijeet Dharmapurikar <adharmap@codeaurora.org> Subject: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq Date: Wed, 1 Sep 2021 16:18:02 +0800 Message-ID: <1630484290-28190-2-git-send-email-quic_fenglinw@quicinc.com> In-Reply-To: <1630484290-28190-1-git-send-email-quic_fenglinw@quicinc.com> References: <1630484290-28190-1-git-send-email-quic_fenglinw@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk
Series	A bunch of fix and optimization patches in spmi-pmic-arb.c \| expand [RESEND,v1,0/9] A bunch of fix and optimization patches in spmi-pmic-arb.c [RESEND,v1,1/9] spmi: pmic-arb: add a print in cleanup_irq [RESEND,v1,2/9] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq [RESEND,v1,3/9] spmi: pmic-arb: check apid against limits before calling irq handler [RESEND,v1,4/9] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status [RESEND,v1,5/9] spmi: pmic-arb: correct duplicate APID to PPID mapping logic [RESEND,v1,6/9] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes [RESEND,v1,7/9] spmi: pmic-arb: support updating interrupt type flags [RESEND,v1,8/9] spmi: pmic-arb: make interrupt support optional [RESEND,v1,9/9] spmi: pmic-arb: increase SPMI transaction timeout delay

Message ID

1630484290-28190-2-git-send-email-quic_fenglinw@quicinc.com

State

Superseded

Headers

From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sboyd@kernel.org>
CC: <collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
	<quic_fenglinw@quicinc.com>,
	Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Subject: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq
Date: Wed, 1 Sep 2021 16:18:02 +0800
Message-ID: <1630484290-28190-2-git-send-email-quic_fenglinw@quicinc.com>
In-Reply-To: <1630484290-28190-1-git-send-email-quic_fenglinw@quicinc.com>
References: <1630484290-28190-1-git-send-email-quic_fenglinw@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Series

A bunch of fix and optimization patches in spmi-pmic-arb.c | expand

Commit Message

Fenglin Wu Sept. 1, 2021, 8:18 a.m. UTC

From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>

The cleanup_irq() was meant to clear and mask interrupts that were
left enabled in the hardware but there was no interrupt handler
registered for it. Add an error print when it gets invoked.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: David Collins <collinsd@codeaurora.org>
Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
---
 drivers/spmi/spmi-pmic-arb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index bbbd311..295e19f 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -489,6 +489,8 @@  static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id)
 	u8 per = ppid & 0xFF;
 	u8 irq_mask = BIT(id);
 
+	dev_err_ratelimited(&pmic_arb->spmic->dev, "%s apid=%d sid=0x%x per=0x%x irq=%d\n",
+			__func__, apid, sid, per, id);
 	writel_relaxed(irq_mask, pmic_arb->ver_ops->irq_clear(pmic_arb, apid));
 
 	if (pmic_arb_write_cmd(pmic_arb->spmic, SPMI_CMD_EXT_WRITEL, sid,

[RESEND,v1,1/9] spmi: pmic-arb: add a print in cleanup_irq

Commit Message

Patch