diff mbox series

[net-next,5/9] ibmvnic: init_tx_pools move loop-invariant code out

Message ID 20210901000812.120968-6-sukadev@linux.ibm.com
State Superseded
Headers show
Series [net-next,1/9] ibmvnic: Consolidate code in replenish_rx_pool() | expand

Commit Message

Sukadev Bhattiprolu Sept. 1, 2021, 12:08 a.m. UTC 
In init_tx_pools() move some loop-invariant code out of the loop.

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Dany Madden Sept. 1, 2021, 1:32 a.m. UTC | #1 
On 2021-08-31 17:08, Sukadev Bhattiprolu wrote:
> In init_tx_pools() move some loop-invariant code out of the loop.

> 

> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>

Reviewed-by: Dany Madden <drt@linux.ibm.com>


> ---

>  drivers/net/ethernet/ibm/ibmvnic.c | 5 ++---

>  1 file changed, 2 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c

> b/drivers/net/ethernet/ibm/ibmvnic.c

> index 4c6739b250df..8894afdb3cb3 100644

> --- a/drivers/net/ethernet/ibm/ibmvnic.c

> +++ b/drivers/net/ethernet/ibm/ibmvnic.c

> @@ -839,11 +839,10 @@ static int init_tx_pools(struct net_device 

> *netdev)

>  	 * allocation, release_tx_pools() will know how many to look for.

>  	 */

>  	adapter->num_active_tx_pools = num_pools;

> +	buff_size = adapter->req_mtu + VLAN_HLEN;

> +	buff_size = ALIGN(buff_size, L1_CACHE_BYTES);

> 

>  	for (i = 0; i < num_pools; i++) {

> -		buff_size = adapter->req_mtu + VLAN_HLEN;

> -		buff_size = ALIGN(buff_size, L1_CACHE_BYTES);

> -

>  		dev_dbg(dev, "Init tx pool %d [%llu, %llu]\n",

>  			i, adapter->req_tx_entries_per_subcrq, buff_size);
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4c6739b250df..8894afdb3cb3 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -839,11 +839,10 @@  static int init_tx_pools(struct net_device *netdev)
 	 * allocation, release_tx_pools() will know how many to look for.
 	 */
 	adapter->num_active_tx_pools = num_pools;
+	buff_size = adapter->req_mtu + VLAN_HLEN;
+	buff_size = ALIGN(buff_size, L1_CACHE_BYTES);
 
 	for (i = 0; i < num_pools; i++) {
-		buff_size = adapter->req_mtu + VLAN_HLEN;
-		buff_size = ALIGN(buff_size, L1_CACHE_BYTES);
-
 		dev_dbg(dev, "Init tx pool %d [%llu, %llu]\n",
 			i, adapter->req_tx_entries_per_subcrq, buff_size);