diff mbox

[v18,5/6] kvm: some fixes to kvm_resamplefds_allowed

Message ID 1435339767-2301-6-git-send-email-eric.auger@linaro.org
State Superseded
Headers show

Commit Message

Auger Eric June 26, 2015, 5:29 p.m. UTC
Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and
associated kvm_resamplefds_allowed boolean. This patch adds
non-KVM version for kvm_resamplefds_enabled and also declares
kvm_resamplefds_allowed in kvm-stub as it is done for fellow
kvm_irqfds_allowed.

Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
 include/sysemu/kvm.h | 1 +
 kvm-stub.c           | 1 +
 2 files changed, 2 insertions(+)

Comments

Peter Maydell June 29, 2015, 9:47 a.m. UTC | #1
On 26 June 2015 at 18:29, Eric Auger <eric.auger@linaro.org> wrote:
> Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and
> associated kvm_resamplefds_allowed boolean. This patch adds
> non-KVM version for kvm_resamplefds_enabled and also declares
> kvm_resamplefds_allowed in kvm-stub as it is done for fellow
> kvm_irqfds_allowed.
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> ---
>  include/sysemu/kvm.h | 1 +
>  kvm-stub.c           | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index ba612fc..983e99e 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -152,6 +152,7 @@ extern bool kvm_readonly_mem_allowed;
>  #define kvm_halt_in_kernel() (false)
>  #define kvm_eventfds_enabled() (false)
>  #define kvm_irqfds_enabled() (false)
> +#define kvm_resamplefds_enabled() (false)
>  #define kvm_msi_via_irqfd_enabled() (false)
>  #define kvm_gsi_routing_allowed() (false)
>  #define kvm_gsi_direct_mapping() (false)
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 977de21..d9ad624 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -24,6 +24,7 @@ bool kvm_kernel_irqchip;
>  bool kvm_async_interrupts_allowed;
>  bool kvm_eventfds_allowed;
>  bool kvm_irqfds_allowed;
> +bool kvm_resamplefds_allowed;
>  bool kvm_msi_via_irqfd_allowed;
>  bool kvm_gsi_routing_allowed;
>  bool kvm_gsi_direct_mapping;
> --
> 1.8.3.2

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

though "kvm: implement kvm_resamplefds_enabled() for !CONFIG_KVM"
might be a more informative subject line if you need to respin
for some other reason.

thanks
-- PMM
Auger Eric June 29, 2015, 9:49 a.m. UTC | #2
On 06/29/2015 11:47 AM, Peter Maydell wrote:
> On 26 June 2015 at 18:29, Eric Auger <eric.auger@linaro.org> wrote:
>> Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and
>> associated kvm_resamplefds_allowed boolean. This patch adds
>> non-KVM version for kvm_resamplefds_enabled and also declares
>> kvm_resamplefds_allowed in kvm-stub as it is done for fellow
>> kvm_irqfds_allowed.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>> ---
>>  include/sysemu/kvm.h | 1 +
>>  kvm-stub.c           | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>> index ba612fc..983e99e 100644
>> --- a/include/sysemu/kvm.h
>> +++ b/include/sysemu/kvm.h
>> @@ -152,6 +152,7 @@ extern bool kvm_readonly_mem_allowed;
>>  #define kvm_halt_in_kernel() (false)
>>  #define kvm_eventfds_enabled() (false)
>>  #define kvm_irqfds_enabled() (false)
>> +#define kvm_resamplefds_enabled() (false)
>>  #define kvm_msi_via_irqfd_enabled() (false)
>>  #define kvm_gsi_routing_allowed() (false)
>>  #define kvm_gsi_direct_mapping() (false)
>> diff --git a/kvm-stub.c b/kvm-stub.c
>> index 977de21..d9ad624 100644
>> --- a/kvm-stub.c
>> +++ b/kvm-stub.c
>> @@ -24,6 +24,7 @@ bool kvm_kernel_irqchip;
>>  bool kvm_async_interrupts_allowed;
>>  bool kvm_eventfds_allowed;
>>  bool kvm_irqfds_allowed;
>> +bool kvm_resamplefds_allowed;
>>  bool kvm_msi_via_irqfd_allowed;
>>  bool kvm_gsi_routing_allowed;
>>  bool kvm_gsi_direct_mapping;
>> --
>> 1.8.3.2
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> though "kvm: implement kvm_resamplefds_enabled() for !CONFIG_KVM"
> might be a more informative subject line if you need to respin
> for some other reason.

OK. Thanks for the whole review

Best Regards

Eric
> 
> thanks
> -- PMM
>
diff mbox

Patch

diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index ba612fc..983e99e 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -152,6 +152,7 @@  extern bool kvm_readonly_mem_allowed;
 #define kvm_halt_in_kernel() (false)
 #define kvm_eventfds_enabled() (false)
 #define kvm_irqfds_enabled() (false)
+#define kvm_resamplefds_enabled() (false)
 #define kvm_msi_via_irqfd_enabled() (false)
 #define kvm_gsi_routing_allowed() (false)
 #define kvm_gsi_direct_mapping() (false)
diff --git a/kvm-stub.c b/kvm-stub.c
index 977de21..d9ad624 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -24,6 +24,7 @@  bool kvm_kernel_irqchip;
 bool kvm_async_interrupts_allowed;
 bool kvm_eventfds_allowed;
 bool kvm_irqfds_allowed;
+bool kvm_resamplefds_allowed;
 bool kvm_msi_via_irqfd_allowed;
 bool kvm_gsi_routing_allowed;
 bool kvm_gsi_direct_mapping;