| Message ID | 20210819052918.6753-1-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: clock: brcm,iproc-clocks: fix armpll properties | expand |
On 8/19/2021 7:29 AM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > armpll clocks (available on Cygnus and Northstar Plus) are simple clocks > with no cells. Adjust binding props #clock-cells and clock-output-names > to handle them. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
On Thu, 19 Aug 2021 07:29:18 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > armpll clocks (available on Cygnus and Northstar Plus) are simple clocks > with no cells. Adjust binding props #clock-cells and clock-output-names > to handle them. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/clock/brcm,iproc-clocks.yaml | 27 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
> > armpll clocks (available on Cygnus and Northstar Plus) are simple clocks > with no cells. Adjust binding props #clock-cells and clock-output-names > to handle them. > Applied to clk-next
diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml index 1174c9aa9934..5ad147d265e6 100644 --- a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml +++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml @@ -61,13 +61,30 @@ properties: maxItems: 1 '#clock-cells': - const: 1 + true clock-output-names: minItems: 1 maxItems: 45 allOf: + - if: + properties: + compatible: + contains: + enum: + - brcm,cygnus-armpll + - brcm,nsp-armpll + then: + properties: + '#clock-cells': + const: 0 + else: + properties: + '#clock-cells': + const: 1 + required: + - clock-output-names - if: properties: compatible: @@ -358,7 +375,6 @@ required: - reg - clocks - '#clock-cells' - - clock-output-names additionalProperties: false @@ -392,3 +408,10 @@ examples: clocks = <&osc2>; clock-output-names = "keypad", "adc/touch", "pwm"; }; + - | + arm_clk@0 { + #clock-cells = <0>; + compatible = "brcm,nsp-armpll"; + clocks = <&osc>; + reg = <0x0 0x1000>; + };