| Message ID | 20210820023521.30716-1-jianjun.wang@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: PCI: mediatek-gen3: Add support for MT8195 | expand |
On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote: > MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > --- > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index 742206dbd965..dcebb1036207 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -48,7 +48,9 @@ allOf: > > properties: > compatible: > - const: mediatek,mt8192-pcie > + oneOf: > + - const: mediatek,mt8192-pcie > + - const: mediatek,mt8195-pcie Use 'enum' instead of oneOf+const. > > reg: > maxItems: 1 > -- > 2.18.0 > >
On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote: > MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. If it is the same, then 8192 should be a fallback compatible. 'The same' means the current driver for 8192 will work unchanged. > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > --- > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index 742206dbd965..dcebb1036207 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -48,7 +48,9 @@ allOf: > > properties: > compatible: > - const: mediatek,mt8192-pcie > + oneOf: > + - const: mediatek,mt8192-pcie > + - const: mediatek,mt8195-pcie > > reg: > maxItems: 1 > -- > 2.18.0 > >
On Tue, 2021-08-24 at 09:40 -0500, Rob Herring wrote: > On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote: > > MT8195 is an ARM platform SoC which has the same PCIe IP with > > MT8192. > > If it is the same, then 8192 should be a fallback compatible. 'The > same' > means the current driver for 8192 will work unchanged. Hi Rob, Thanks for your review. Yes, the controller driver works fine in the MT8195 platform without any change, and we would like to use the compatible string in device tree as follows: "mediatek,mt8195-pcie", "mediatek,mt8192-pcie" Thanks. > > > > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > > --- > > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 > > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml > > index 742206dbd965..dcebb1036207 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -48,7 +48,9 @@ allOf: > > > > properties: > > compatible: > > - const: mediatek,mt8192-pcie > > + oneOf: > > + - const: mediatek,mt8192-pcie > > + - const: mediatek,mt8195-pcie > > > > reg: > > maxItems: 1 > > -- > > 2.18.0 > > > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml index 742206dbd965..dcebb1036207 100644 --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml @@ -48,7 +48,9 @@ allOf: properties: compatible: - const: mediatek,mt8192-pcie + oneOf: + - const: mediatek,mt8192-pcie + - const: mediatek,mt8195-pcie reg: maxItems: 1
MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> --- Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)