| Message ID | 20210819201936.7390-3-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Thu, Aug 19, 2021 at 11:19:35PM +0300, Sakari Ailus wrote: > Allow building gpio-tps68470 driver as a module. The intel_skl_int3472 is > a module anyway, so making this a builtin does not really help setting up > this one before a dependent module probes. Fine with me, Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/gpio/Kconfig | 2 +- > drivers/gpio/gpio-tps68470.c | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index fab571016adf..8911c2df97d1 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -1378,7 +1378,7 @@ config GPIO_TPS65912 > This driver supports TPS65912 gpio chip > > config GPIO_TPS68470 > - bool "TPS68470 GPIO" > + tristate "TPS68470 GPIO" > depends on INTEL_SKL_INT3472 > help > Select this option to enable GPIO driver for the TPS68470 > diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c > index 423b7bc30ae8..0ab88ef241de 100644 > --- a/drivers/gpio/gpio-tps68470.c > +++ b/drivers/gpio/gpio-tps68470.c > @@ -155,4 +155,6 @@ static struct platform_driver tps68470_gpio_driver = { > .probe = tps68470_gpio_probe, > }; > > -builtin_platform_driver(tps68470_gpio_driver) > +module_platform_driver(tps68470_gpio_driver); > + > +MODULE_LICENSE("GPL"); > -- > 2.30.2 >
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index fab571016adf..8911c2df97d1 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1378,7 +1378,7 @@ config GPIO_TPS65912 This driver supports TPS65912 gpio chip config GPIO_TPS68470 - bool "TPS68470 GPIO" + tristate "TPS68470 GPIO" depends on INTEL_SKL_INT3472 help Select this option to enable GPIO driver for the TPS68470 diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c index 423b7bc30ae8..0ab88ef241de 100644 --- a/drivers/gpio/gpio-tps68470.c +++ b/drivers/gpio/gpio-tps68470.c @@ -155,4 +155,6 @@ static struct platform_driver tps68470_gpio_driver = { .probe = tps68470_gpio_probe, }; -builtin_platform_driver(tps68470_gpio_driver) +module_platform_driver(tps68470_gpio_driver); + +MODULE_LICENSE("GPL");
Allow building gpio-tps68470 driver as a module. The intel_skl_int3472 is a module anyway, so making this a builtin does not really help setting up this one before a dependent module probes. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-tps68470.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)