| Message ID | 20210818070209.1540451-1-michal.vokac@ysoft.com |
|---|---|
| State | Accepted |
| Commit | 9b663b34c94a78f39fa2c7a8271b1f828b546e16 |
| Headers | show |
| Series | [1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe | expand |
On Wed 2021-08-18 09:02:08, Michal Vokáč wrote: > Since the LED multicolor framework support was added in commit > 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > LEDs on this platform stopped working. > > Author of the framework attempted to accommodate this DT to the > framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property > to the lp5562 channel node") but that is not sufficient. A color property > is now required even if the multicolor framework is not used, otherwise > the driver probe fails: > > lp5562: probe of 1-0030 failed with error -22 > > Add the color property to fix this. > > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > Cc: <stable@vger.kernel.org> > Cc: linux-leds@vger.kernel.org > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Acked-by: Pavel Machek <pavel@ucw.cz>
On Wed 2021-08-18 09:02:09, Michal Vokáč wrote: > Since the reg property was added to each channel node in commit > b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 > channel node") it is possible to skip unused channels. > > Remove the actually unused white LED channel. > > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Acked-by: Pavel Machek <pavel@ucw.cz>
On 18. 08. 21 9:02, Michal Vokáč wrote: > Since the LED multicolor framework support was added in commit > 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > LEDs on this platform stopped working. > > Author of the framework attempted to accommodate this DT to the > framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property > to the lp5562 channel node") but that is not sufficient. A color property > is now required even if the multicolor framework is not used, otherwise > the driver probe fails: > > lp5562: probe of 1-0030 failed with error -22 > > Add the color property to fix this. > > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > Cc: <stable@vger.kernel.org> > Cc: linux-leds@vger.kernel.org > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Hi Shawn, gentle ping on this little series. Thank you, Michal
Hi Michal, On Wed, Aug 18, 2021 at 4:02 AM Michal Vokáč <michal.vokac@ysoft.com> wrote: > > Since the LED multicolor framework support was added in commit > 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > LEDs on this platform stopped working. > > Author of the framework attempted to accommodate this DT to the > framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property > to the lp5562 channel node") but that is not sufficient. A color property > is now required even if the multicolor framework is not used, otherwise > the driver probe fails: > > lp5562: probe of 1-0030 failed with error -22 > > Add the color property to fix this. > > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > Cc: <stable@vger.kernel.org> > Cc: linux-leds@vger.kernel.org > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index 7d2c72562c73..8c796551352b 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -5,6 +5,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/pwm/pwm.h> / { @@ -271,6 +272,7 @@ chan@0 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <0>; + color = <LED_COLOR_ID_RED>; }; chan@1 { @@ -278,6 +280,7 @@ chan@1 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <1>; + color = <LED_COLOR_ID_GREEN>; }; chan@2 { @@ -285,6 +288,7 @@ chan@2 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <2>; + color = <LED_COLOR_ID_BLUE>; }; chan@3 { @@ -292,6 +296,7 @@ chan@3 { led-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>; reg = <3>; + color = <LED_COLOR_ID_WHITE>; }; };
Since the LED multicolor framework support was added in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") LEDs on this platform stopped working. Author of the framework attempted to accommodate this DT to the framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") but that is not sufficient. A color property is now required even if the multicolor framework is not used, otherwise the driver probe fails: lp5562: probe of 1-0030 failed with error -22 Add the color property to fix this. Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: <stable@vger.kernel.org> Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 5 +++++ 1 file changed, 5 insertions(+)